Re: [DISCUSS] JUnit 5 Migration

2022-04-15 Thread Mingliang Liu
>Some modules are already migrated by us, but the code hasn't been merged since we still have some pending details to discuss. I see you have created sub-task JIRAs for those modules in the umbrella JIRA FLINK-25325 . But they are still unassigned

Re: [DISCUSS] JUnit 5 Migration

2022-01-05 Thread Hang Ruan
Hi, Ryan, Thanks a lot for helping with the migration. Some modules are already migrated by us, but the code hasn't been merged since we still have some pending details to discuss. These modules are flink-runtime, flink-core, flink-test-utils, flink-runtime-web, flink-yarn, flink-kuberbetes, flin

Re: [DISCUSS] JUnit 5 Migration

2022-01-05 Thread Ryan Skraba
Hello! I can help out with the effort -- I've got a bit of experience with JUnit 4 and 5 migration, and it looks like even with the AssertJ scripts there's going to be a lot of mechanical and manual work to be done. The migration document looks pretty comprehensive! For the remaining topics to b

Re: [DISCUSS] JUnit 5 Migration

2021-12-17 Thread Jing Ge
Thanks Hang and Qingsheng for your effort and starting this discussion. As additional information, I've created an umbrella ticket( https://issues.apache.org/jira/browse/FLINK-25325). It is recommended to create all JUnit5 migration related tasks under it, So we could track the whole migration easi