Re: [DISCUSS] Flexible Custom Commit Policy with Parameter Passing

2023-06-26 Thread yuxia
: 星期一, 2023年 6 月 26日 下午 5:32:17 主题: Re: [DISCUSS] Flexible Custom Commit Policy with Parameter Passing Hi yuxia, Thank you for reviewing the code. Specifically, when users set *'sink.partition-commit.policy.class.parameters=''*, the 'parameters' will not be null but will b

Re: [DISCUSS] Flexible Custom Commit Policy with Parameter Passing

2023-06-26 Thread Dunn Bangui
said in the previous email: > >> > >> "But will it better to make it asList ? Something > >> like:`.stringType().asList()`." => "But will it better to make it no > >> default value? Something like:`.stringType().asList().noDefaultValue`."

Re: [DISCUSS] Flexible Custom Commit Policy with Parameter Passing

2023-06-24 Thread yuxia
星期日, 2023年 6 月 25日 上午 10:34:50 主题: Re: [DISCUSS] Flexible Custom Commit Policy with Parameter Passing Hi, Yuxia. Could you please provide me with an update on the review process? I am eager to move forward and would appreciate any guidance or feedback you can provide. Best regards, late Drag

Re: [DISCUSS] Flexible Custom Commit Policy with Parameter Passing

2023-06-24 Thread Dunn Bangui
t;> >> Best regards, >> Yuxia >> >> - 原始邮件 ----- >> 发件人: "yuxia" >> 收件人: "dev" >> 发送时间: 星期三, 2023年 6 月 21日 上午 10:25:47 >> 主题: Re: [DISCUSS] Flexible Custom Commit Policy with Parameter Passing >> >> Hi, Bangui

Re: [DISCUSS] Flexible Custom Commit Policy with Parameter Passing

2023-06-20 Thread Gary Ccc
- 原始邮件 - > 发件人: "yuxia" > 收件人: "dev" > 发送时间: 星期三, 2023年 6 月 21日 上午 10:25:47 > 主题: Re: [DISCUSS] Flexible Custom Commit Policy with Parameter Passing > > Hi, Bangui Dunn. > Thanks for reaching us out. > Generally + 1 for the configuration. But

Re: [DISCUSS] Flexible Custom Commit Policy with Parameter Passing

2023-06-20 Thread yuxia
- 发件人: "yuxia" 收件人: "dev" 发送时间: 星期三, 2023年 6 月 21日 上午 10:25:47 主题: Re: [DISCUSS] Flexible Custom Commit Policy with Parameter Passing Hi, Bangui Dunn. Thanks for reaching us out. Generally + 1 for the configuration. But will it better to make it asList? Something li

Re: [DISCUSS] Flexible Custom Commit Policy with Parameter Passing

2023-06-20 Thread yuxia
Hi, Bangui Dunn. Thanks for reaching us out. Generally + 1 for the configuration. But will it better to make it asList? Something like: `.stringType().asList()`. Best regards, Yuxia - 原始邮件 - 发件人: "Gary Ccc" 收件人: "dev" 发送时间: 星期二, 2023年 6 月 20日 下午 5:44:10 主题: [DISCUSS] Flexible Custom