Re: [DISCUSS] FLIP-XXX: Introduce Flink SQL variables

2024-04-03 Thread Ferenc Csaky
Hi Jeyhun, Thank you for your questions, please see my answers below. > What is its impact on query optimization because resolving > variables at the parsing stage might affect query optimization. The approach I mentioned in the FLIP would not affect query optimization, as it restricts variables

Re: [DISCUSS] FLIP-XXX: Introduce Flink SQL variables

2024-04-01 Thread Jeyhun Karimov
Hi Ferenc, Thanks for the proposal. Sounds like a good idea! I have a few questions on that: - What is its impact on query optimization because resolving variables at the parsing stage might affect query optimization. - What is the scope of variables? I mean when and how they override each other

Re: [DISCUSS] FLIP-XXX: Introduce Flink SQL variables

2024-03-28 Thread Ferenc Csaky
Hi, Jim, Yanfei, Thanks for your comments! Let me reply in the order of the messages. > I'd prefer sticking to the SQL standard if possible. Would > it be possible / sensible to allow for each syntax, perhaps > managed by a config setting? Correct me if I am wrong, but AFAIK variables are not p

Re: [DISCUSS] FLIP-XXX: Introduce Flink SQL variables

2024-03-27 Thread Yanfei Lei
Hi Ferenc, Thanks for the proposal, using SQLvariables to exclude environment-specific configuration from code sounds like a good idea. I'm new to Flink SQL and I'm curious if these variables can be calculated from statements or expression [1]? In FLIP, it seems that the values are in the form of

Re: [DISCUSS] FLIP-XXX: Introduce Flink SQL variables

2024-03-27 Thread Jim Hughes
Hi Ferenc, Looks like a good idea. I'd prefer sticking to the SQL standard if possible. Would it be possible / sensible to allow for each syntax, perhaps managed by a config setting? Cheers, Jim On Tue, Mar 26, 2024 at 6:59 AM Ferenc Csaky wrote: > Hello devs, > > I would like to start a di