Re: [DISCUSS] FLIP-51: Rework of the Expression Design

2019-08-15 Thread Timo Walther
Hi, regarding the LegacyTypeInformation esp. for decimals. I don't have a clear answer yet, but I think it should not limit us. If possible it should travel through the type inference and we only need some special cases at some locations e.g. when computing the leastRestrictive. E.g. the logi

Re: [DISCUSS] FLIP-51: Rework of the Expression Design

2019-08-15 Thread JingsongLee
Hi @Timo Walther @Dawid Wysakowicz: Now, flink-planner have some legacy DataTypes: like: legacy decimal, legacy basic array type info... And If the new type inference infer a Decimal/VarChar with precision, there should will fail in TypeConversions. The better we do on DataType, the more problem

Re: [DISCUSS] FLIP-51: Rework of the Expression Design

2019-08-15 Thread JingsongLee
Hi jark: I'll add a chapter to list blink planner extended functions. Best, Jingsong Lee -- From:Jark Wu Send Time:2019年8月15日(星期四) 05:12 To:dev Subject:Re: [DISCUSS] FLIP-51: Rework of the Expression Design Thanks Jingsong for

Re: [DISCUSS] FLIP-51: Rework of the Expression Design

2019-08-14 Thread Jark Wu
Thanks Jingsong for starting the discussion. The general design of the FLIP looks good to me. +1 for the FLIP. It's time to get rid of the old Expression! Regarding to the function behavior, shall we also include new functions from blink planner (e.g. LISTAGG, REGEXP, TO_DATE, etc..) ? Best, Ja

Re: [DISCUSS] FLIP-51: Rework of the Expression Design

2019-08-14 Thread Timo Walther
Hi Jingsong, thanks for writing down this FLIP. Big +1 from my side to finally get rid of PlannerExpressions and have consistent and well-defined behavior for Table API and SQL updated to FLIP-37. We might need to discuss some of the behavior of particular functions but this should not affec