Hi all,
Thanks for the discussion. I think all the comments and questions have
been addressed. I will open the voting thread today.
Best,
Xuannan
On Tue, Jan 2, 2024 at 11:59 AM Xuannan Su wrote:
>
> Hi all,
>
> Thank you for all your comments! The FLIP has been updated
> accordingly. Please l
Hi all,
Thank you for all your comments! The FLIP has been updated
accordingly. Please let me know if you have any further questions or
comments.
Also, note that many people are on Christmas break, so we will keep
the discussion open for another week.
Best,
Xuannan
On Wed, Dec 27, 2023 at 5:20
> After some investigation, it turns out those options of input/output
> format are only publicly exposed in the DataSet docs[2], which is
> deprecated. Thus, marking them as deprecated and removed in Flink 2.0
> looks fine to me.
Thanks Xuannan for the detailed investigation, if so, deprecate the
Hi, Rui Fan.
Thanks for this FLIP.
I think the key of LOCAL_NUMBER_TASK_MANAGER is better as
'minicluster.number-of-taskmanagers' or 'minicluster.taskmanager-number'
instead of 'minicluster.number-taskmanager'.
Best,
Hang
Xuannan Su 于2023年12月27日周三 12:40写道：
> Hi Xintong and Rui,
>
> Thanks for
Hi Xintong and Rui,
Thanks for the quick feedback and the suggestions.
> 1. I think the default value for `TASK_MANAGER_LOG_PATH_KEY` should be "no
> default".
I have considered both ways of describing the default value. However,
I found out that some of the configurations, such as `web.tmpdir`,
>
> Configuration has a `public T get(ConfigOption option)` method.
> Could we remove all `Xxx getXxx(ConfigOption configOption)` methods?
Note: all `public void setXxx(ConfigOption key, Xxx value)` methods
> can be replaced with `public Configuration set(ConfigOption option,
> T value)` as we
>
> These features don't have a public option, but they work. I'm not sure
> whether these features are used by some advanced users.
> Actually, I think some of them are valuable! For example:
>
> - ConfigConstants.YARN_CONTAINER_START_COMMAND_TEMPLATE
> allows users to define the start command o
In addition to what is written in FLIP, I found some methods of
Configuration
are not necessary. And I wanna hear more thoughts from all of you.
Configuration has a `public T get(ConfigOption option)` method.
Could we remove all `Xxx getXxx(ConfigOption configOption)` methods?
Such as:
- public i
Thanks Xintong for the quick feedback and the good suggestions!
> 1. I think the default value for `TASK_MANAGER_LOG_PATH_KEY` should be "no
> default". We can explain in the description that if not configured,
> `System.getProperty("log.file")` will be used, but that is not a default
> value.
Ex
Thanks for the efforts, Rui and Xuannan.
I think it's a good idea to migrate string-key configuration accesses to
ConfigOption-s in general.
I have a few suggestions / questions regarding the FLIP.
1. I think the default value for `TASK_MANAGER_LOG_PATH_KEY` should be "no
default". We can explai
10 matches
Mail list logo
