Hi all,
Thank you for the valuable input.
Since there are no new objections or suggestions, I will open a voting
thread in two days.
Best,
Feng
On Thu, Dec 21, 2023 at 6:58 PM Benchao Li wrote:
> I'm glad to hear that this is in your plan. Sorry that I overlooked
> the PoC link in the FLIP p
I'm glad to hear that this is in your plan. Sorry that I overlooked
the PoC link in the FLIP previously, I'll go over the code of PoC, and
post here if there are any more concerns.
Xuyang 于2023年12月21日周四 10:39写道：
>
> Hi, Benchao.
>
>
> When Feng Jin and I tried the poc together, we found that whe
I didn't see your POC code, so I assumed that you'll need to add
SqlStdOperatorTable#DEFAULT and
SqlStdOperatorTable#ARGUMENT_ASSIGNMENT to FlinkSqlOperatorTable, am I
right?
If yes, this would enable many builtin functions to allow default and
optional arguments, for example, `select md5(DEFAULT)
Thanks Feng for driving this, it's a very useful feature.
In the FLIP, you mentioned that
> During POC verification, bugs were discovered in Calcite that caused issues
> during the validation phase. We need to modify the SqlValidatorImpl and
> SqlToRelConverter to address these problems.
Could
Hi Timo
Thanks for your reply.
> 1) ArgumentNames annotation
I'm sorry for my incorrect expression. argumentNames is a method of
FunctionHints. We should introduce a new arguments method to replace this
method and return Argument[].
I updated the FLIP doc about this part.
> 2) Evolution of Fun
Hi Feng,
thank you for proposing this FLIP. This nicely completes FLIP-65 which
is great for usability.
I read the FLIP and have some feedback:
1) ArgumentNames annotation
> Deprecate the ArgumentNames annotation as it is not user-friendly for
specifying argument names with optional config
