Re: [DISCUSS] FLIP-33: Terminate/Suspend Job with Savepoint

2019-03-12 Thread Kostas Kloudas
Thanks a lot Aljoscha! On Tue, Mar 12, 2019 at 2:50 PM Aljoscha Krettek wrote: > I agree and already created a Jira issue for removing the old “stop” > feature as preparation: https://issues.apache.org/jira/browse/FLINK-11889 > > > Aljoscha > >

Re: [DISCUSS] FLIP-33: Terminate/Suspend Job with Savepoint

2019-03-12 Thread Aljoscha Krettek
I agree and already created a Jira issue for removing the old “stop” feature as preparation: https://issues.apache.org/jira/browse/FLINK-11889 Aljoscha > On 7. Mar 2019, at 11:08, Kostas Kloudas wrote: > > Hi, > > Thanks for the comments. >

Re: [DISCUSS] FLIP-33: Terminate/Suspend Job with Savepoint

2019-03-07 Thread Kostas Kloudas
Hi, Thanks for the comments. I agree with the Ufuk's and Elias' proposal. - "cancel" remains the good old "cancel" - "terminate" becomes "stop --drain-with-savepoint" - "suspend" becomes "stop --with-savepoint" - "cancel-with-savepoint" is subsumed by "stop --with-savepoint" As you see from the

Re: [DISCUSS] FLIP-33: Terminate/Suspend Job with Savepoint

2019-03-06 Thread Ufuk Celebi
I really like this effort. I think the original plan for "cancel-with-savepoint" was always to just be a workaround until we arrived at a better solution as proposed here. Regarding the FLIP, I agree with Elias comments. I think the number of termination modes the FLIP introduces can be overwhelmi

Re: [DISCUSS] FLIP-33: Terminate/Suspend Job with Savepoint

2019-03-05 Thread Elias Levy
Apologies for the late reply. I think this is badly needed, but I fear we are adding complexity by introducing yet two more stop commands. We'll have: cancel, stop, terminate. and suspend. We basically want to do two things: terminate a job with prejudice or stop a job safely. For the former "c

Re: [DISCUSS] FLIP-33: Terminate/Suspend Job with Savepoint

2019-02-12 Thread Biao Liu
Thanks for bringing us this discussion. I like the idea. It's really useful in production scenario. +1 for the proposal. jincheng sun 于2019年2月13日周三 上午9:35写道: > Thank you for starting the discussion about cancel-with-savepoint Kostas. > > +1 for the FLIP. > > Cheers, > Jincheng > > Fabian Hueske

Re: [DISCUSS] FLIP-33: Terminate/Suspend Job with Savepoint

2019-02-12 Thread Guowei Ma
thanks for starting this discussion. It is a very cool feature. +1 for the FLIP Best Guowei jincheng sun 于2019年2月13日周三 上午9:35写道: > Thank you for starting the discussion about cancel-with-savepoint Kostas. > > +1 for the FLIP. > > Cheers, > Jincheng > > Fabian Hueske 于2019年2月13日周三 上午4:31写道: >

Re: [DISCUSS] FLIP-33: Terminate/Suspend Job with Savepoint

2019-02-12 Thread jincheng sun
Thank you for starting the discussion about cancel-with-savepoint Kostas. +1 for the FLIP. Cheers, Jincheng Fabian Hueske 于2019年2月13日周三 上午4:31写道: > Thanks for working on improving cancel-with-savepoint Kostas. > Distinguishing the termination modes would be a big step forward, IMO. > > Btw. th

Re: [DISCUSS] FLIP-33: Terminate/Suspend Job with Savepoint

2019-02-12 Thread Fabian Hueske
Thanks for working on improving cancel-with-savepoint Kostas. Distinguishing the termination modes would be a big step forward, IMO. Btw. there is already another FLIP-33 on the way. This one should be FLIP-34. Cheers, Fabian Am Di., 12. Feb. 2019 um 18:49 Uhr schrieb Stephan Ewen : > Thank you

Re: [DISCUSS] FLIP-33: Terminate/Suspend Job with Savepoint

2019-02-12 Thread Stephan Ewen
Thank you for starting this feature discussion. This is a feature that has been requested various times, great to see it happening. +1 for this FLIP On Tue, Feb 12, 2019 at 5:28 PM Kostas Kloudas wrote: > Hi everyone, > > A commonly used functionality offered by Flink is the > "cancel-with-sav