Re: [DISCUSS] FLIP-311: Support Call Stored Procedure

2023-06-19 Thread Jing Ge
], I would like to start voting next monday > > (6/12). > > > > > > [1] > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-311%3A+Support+Call+Stored+Procedure > > > > > > > > > Best regards, > > > Yuxia > > > > > >

Re: [DISCUSS] FLIP-311: Support Call Stored Procedure

2023-06-13 Thread yuxia
Yes, you're right. Best regards, Yuxia - 原始邮件 - 发件人: "Jing Ge" 收件人: "dev" 发送时间: 星期三, 2023年 6 月 14日 上午 4:46:58 主题: Re: [DISCUSS] FLIP-311: Support Call Stored Procedure Hi yuxia, Thanks for your proposal and sorry for the late reply. The FLIP is in good sh

Re: [DISCUSS] FLIP-311: Support Call Stored Procedure

2023-06-13 Thread Jing Ge
; > > > > Best regards, > > Yuxia > > > > - 原始邮件 ----- > > 发件人: "Martijn Visser" > > 收件人: "dev" > > 发送时间: 星期二, 2023年 6 月 06日 下午 3:57:56 > > 主题: Re: [DISCUSS] FLIP-311: Support Call Stored Procedure > > > &g

Re: [DISCUSS] FLIP-311: Support Call Stored Procedure

2023-06-08 Thread Jark Wu
t; > [1] > https://cwiki.apache.org/confluence/display/FLINK/FLIP-311%3A+Support+Call+Stored+Procedure > > > Best regards, > Yuxia > > - 原始邮件 - > 发件人: "Martijn Visser" > 收件人: "dev" > 发送时间: 星期二, 2023年 6 月 06日 下午 3:57:56 > 主题: Re: [DISCUSS]

Re: [DISCUSS] FLIP-311: Support Call Stored Procedure

2023-06-07 Thread yuxia
: "Martijn Visser" 收件人: "dev" 发送时间: 星期二, 2023年 6 月 06日 下午 3:57:56 主题: Re: [DISCUSS] FLIP-311: Support Call Stored Procedure Hi Yuxia, Thanks for the clarification. I would be +0 overall, because I think without actually allowing creation/customization of stored procedure

Re: [DISCUSS] FLIP-311: Support Call Stored Procedure

2023-06-06 Thread Martijn Visser
est regards, > Yuxia > > ----- 原始邮件 ----- > 发件人: "Martijn Visser" > 收件人: "dev" > 发送时间: 星期一, 2023年 6 月 05日 下午 8:35:44 > 主题: Re: [DISCUSS] FLIP-311: Support Call Stored Procedure > > Hi Yuxia, > > Thanks for the FLIP. I have a couple of questions: >

Re: [DISCUSS] FLIP-311: Support Call Stored Procedure

2023-06-05 Thread yuxia
发送时间: 星期一, 2023年 6 月 05日 下午 8:35:44 主题: Re: [DISCUSS] FLIP-311: Support Call Stored Procedure Hi Yuxia, Thanks for the FLIP. I have a couple of questions: 1. The syntax talks about how to CALL or SHOW the available stored procedures, but not on how to create one. Will there not be a SQL syntax

Re: [DISCUSS] FLIP-311: Support Call Stored Procedure

2023-06-05 Thread Martijn Visser
d dicussion. Let's keep this FLIP focus. > > [1] > https://cwiki.apache.org/confluence/display/FLINK/FLIP-297%3A+Improve+Auxiliary+Sql+Statements > > Best regards, > Yuxia > > - 原始邮件 - > 发件人: "Jane Chan" > 收件人: "dev" > 发送时间: 星期六, 2023年

Re: [DISCUSS] FLIP-311: Support Call Stored Procedure

2023-06-04 Thread yuxia
Chan" 收件人: "dev" 发送时间: 星期六, 2023年 6 月 03日 下午 7:04:39 主题: Re: [DISCUSS] FLIP-311: Support Call Stored Procedure Hi Yuxia, Thanks for bringing this to the discussion. The call procedure is a widely used feature and will be very useful for users. I just have one question regarding the

Re: [DISCUSS] FLIP-311: Support Call Stored Procedure

2023-06-03 Thread Jane Chan
s > > about exposing too much too early to procedure devs. If someday we find > we > > will need `TableEnvironment` to custom a procedure, we can then add a > > method like `getTableEnvironment()` in `ProcedureContext`. > > > > Best regards, > > Yuxia > > >

Re: [DISCUSS] FLIP-311: Support Call Stored Procedure

2023-06-03 Thread Benchao Li
ableEnvironment` to custom a procedure, we can then add a > method like `getTableEnvironment()` in `ProcedureContext`. > > Best regards, > Yuxia > > - 原始邮件 - > 发件人: "Benchao Li" > 收件人: "dev" > 发送时间: 星期四, 2023年 6 月 01日 下午 12:58:08 > 主题:

Re: [DISCUSS] FLIP-311: Support Call Stored Procedure

2023-06-01 Thread yuxia
7;t be effective as other sql statements since these table configurations are mainly be considerd by the TableEnvironment. 4: Yes, you're right. Best regards, Yuxia - 原始邮件 - 发件人: "Paul Lam" 收件人: "dev" 发送时间: 星期四, 2023年 6 月 01日 下午 6:34:24 主题: Re: [DISCUSS]

Re: [DISCUSS] FLIP-311: Support Call Stored Procedure

2023-06-01 Thread Paul Lam
gin: > "But we can't get the `StreamExecutionEnvironment` which is the entrypoint to > build datastream from `TableEnvironment`; > > Best regards, > Yuxia > > - 原始邮件 - > 发件人: "yuxia" > 收件人: "dev" > 发送时间: 星期四, 2023年 6 月 01日 下午 4

Re: [DISCUSS] FLIP-311: Support Call Stored Procedure

2023-06-01 Thread yuxia
- 原始邮件 - 发件人: "Benchao Li" 收件人: "dev" 发送时间: 星期四, 2023年 6 月 01日 下午 12:58:08 主题: Re: [DISCUSS] FLIP-311: Support Call Stored Procedure Thanks Yuxia for opening this discussion, The general idea looks good to me, I only have one question about the `ProcedureCo

Re: [DISCUSS] FLIP-311: Support Call Stored Procedure

2023-06-01 Thread yuxia
ot; 发送时间: 星期四, 2023年 6 月 01日 下午 12:58:08 主题: Re: [DISCUSS] FLIP-311: Support Call Stored Procedure Thanks Yuxia for opening this discussion, The general idea looks good to me, I only have one question about the `ProcedureContext#getExecutionEnvironment`. Why are you proposing to return a `Str

Re: [DISCUSS] FLIP-311: Support Call Stored Procedure

2023-05-31 Thread Benchao Li
t; > > > [1]: https://iceberg.apache.org/docs/latest/spark-procedures/#migrate > > [2]: > https://github.com/apache/iceberg/blob/601c5af9b6abded79dabeba177331310d5487f43/spark/v3.2/spark/src/main/java/org/apache/spark/sql/connector/iceberg/catalog/Procedure.java#L44 > > > > Best regar

Re: [DISCUSS] FLIP-311: Support Call Stored Procedure

2023-05-30 Thread Jingsong Li
k/sql/connector/iceberg/catalog/Procedure.java#L44 > > Best regards, > Yuxia > > - 原始邮件 - > 发件人: "Jingsong Li" > 收件人: "dev" > 发送时间: 星期一, 2023年 5 月 29日 下午 2:42:04 > 主题: Re: [DISCUSS] FLIP-311: Support Call Stored Procedure > > Thanks Yux

Re: [DISCUSS] FLIP-311: Support Call Stored Procedure

2023-05-30 Thread yuxia
Best regards, Yuxia - 原始邮件 ----- 发件人: "Jingsong Li" 收件人: "dev" 发送时间: 星期一, 2023年 5 月 29日 下午 2:42:04 主题: Re: [DISCUSS] FLIP-311: Support Call Stored Procedure Thanks Yuxia for the proposal. > CALL [catalog_name.][database_name.]procedure_name ([ expression [, >

Re: [DISCUSS] FLIP-311: Support Call Stored Procedure

2023-05-28 Thread Jingsong Li
Thanks Yuxia for the proposal. > CALL [catalog_name.][database_name.]procedure_name ([ expression [, > expression]* ] ) The expression can be a function call. Does this need to be a function call? Do you have some example? > Procedure returns T[] Procedure looks like a TableFunction, do you co