Re: [DISCUSS] FLIP-262 MongoDB Connector

2022-09-30 Thread Jiabao Sun
Hi Qingsheng, Thanks For the feedback. Other metrics mentioned in FLIP-33, we will also implement it. Best, Jiabao -- From:Qingsheng Ren Send Time:2022年9月28日(星期三) 18:36 To:孙家宝 Cc:dev Subject:Re: [DISCUSS] FLIP-262 MongoDB Connector

Re: [DISCUSS] FLIP-262 MongoDB Connector

2022-09-28 Thread Qingsheng Ren
Thanks for the update Jiabao. c. It’ll be nice to have all metrics defined in FLIP-33 in the connector. Also it’s better to have some MongoDB specific metrics, which will be very helpful for users to monitor their jobs. Best, Qingsheng > On Sep 27, 2022, at 11:59, Jiabao Sun

Re: [DISCUSS] FLIP-262 MongoDB Connector

2022-09-26 Thread Jiabao Sun
Hi Qingsheng, Thanks for the great suggestion. a. Currently we have implemented the Source of FLIP-177 in https://github.com/apache/flink/pull/20848. Sorry for some mistakes in the Public Interface of FLIP-262, the interface of Sink has been adjusted from FLIP-143 to FLIP-177. b. The AsyncWriter

Re: [DISCUSS] FLIP-262 MongoDB Connector

2022-09-26 Thread Qingsheng Ren
Hi Jiabao, Thanks for the FLIP! Very glad to see having a new connector in Flink eco-system, so overall +1 from my side. In addition to those FLIPs you mention in the proposal, here’s some other FLIPs that you may be interested in: a. FLIP-177 [1] extended Sink API by Sink API v2 with some add

Re: [DISCUSS] FLIP-262 MongoDB Connector

2022-09-22 Thread Martijn Visser
Hi Jiabao, Thanks for creating the FLIP. It looks like there's is enthusiasm for a MongoDB connector so that's good. What is also good to mention is that you have already prepared a PR at https://github.com/apache/flink/pull/20848 - That would need to move to the dedicated repository. Overall +1