Re: [DISCUSS][2.0] FLIP-352: Use camelCast for all REST API fields/parameters

2023-07-25 Thread Xintong Song
Thanks for the explanation. I'd be fine with not bumping the version, if it requires that much effort. Best, Xintong On Tue, Jul 25, 2023 at 4:44 PM Chesnay Schepler wrote: > On 25/07/2023 04:09, Xintong Song wrote: > > In this case, I wonder if it makes sense to bump the REST API version t

Re: [DISCUSS][2.0] FLIP-352: Use camelCast for all REST API fields/parameters

2023-07-25 Thread Chesnay Schepler
On 25/07/2023 04:09, Xintong Song wrote: In this case, I wonder if it makes sense to bump the REST API version to V2. That should allow us to gradually phase out the old APIs without the above mentioned problems. It's ultimately possible do do that; it just implies duplicating _a lot_ classes an

Re: [DISCUSS][2.0] FLIP-352: Use camelCast for all REST API fields/parameters

2023-07-24 Thread Xintong Song
I think adding the convention to our code-style guidelines [1] makes sense. In addition, I wonder if this can be enforced with some code-style checking tools. What impact (if any) will there be on existing users? Virtually every tooling against the REST API will break. Users that > generated a cl

Re: [DISCUSS][2.0] FLIP-352: Use camelCast for all REST API fields/parameters

2023-07-24 Thread Jing Ge
camel case is the standard code convention in Java since day one[1]. We don't need to describe it again for Flink. Legacy hyphens might be coded by contributors with other language backgrounds. If we really care about it, it might make sense to add the reference. It would be great if the FLIP coul

Re: [DISCUSS][2.0] FLIP-352: Use camelCast for all REST API fields/parameters

2023-07-24 Thread Matthias Pohl
Do we have conventions on how the REST API should be formatted written down somewhere? Checking our coding conventions [1] didn't reveal anything. We could refer to a style guide like [2] to cover this topic. That would also include the camel-cased JSON fields. [1] https://flink.apache.org/how-to