Re: Re: Re: Re: Re: [DISCUSS] FLIP-239: Port JDBC Connector Source to FLIP-27

2022-08-31 Thread Martijn Visser
It would be great if João could help finalize the PR. In case he doesn't have the permission to update the FLIP, please reach out to me so we can get that sorted. Op wo 10 aug. 2022 om 04:41 schreef Roc Marshal : > Hi, > Martijn, Boto. > I just complete the design of the source and the skeleton

RE: Re: Re: Re: Re: [DISCUSS] FLIP-239: Port JDBC Connector Source to FLIP-27

2022-08-09 Thread Roc Marshal
Hi, Martijn, Boto. I just complete the design of the source and the skeleton design of the sink at present. I think the current Flip is missing part of the sink design. @Boto Would you like to complete the sink part directly on the FLIP page? Looking forward to your reply. On 2022/08/01 13:42

Re: Re: Re: Re: [DISCUSS] FLIP-239: Port JDBC Connector Source to FLIP-27

2022-08-01 Thread Martijn Visser
Hi, There is currently already a PR submitted to port the JDBC interface to the new interfaces. Can we make sure that this FLIP is being finalized, so that you and other maintainers can work on getting the PRs correct and eventually merged in? Best regards, Martijn Op ma 4 jul. 2022 om 16:38 sc

Re: Re: Re: Re: [DISCUSS] FLIP-239: Port JDBC Connector Source to FLIP-27

2022-07-04 Thread Martijn Visser
Hi Roc, Thanks for the FLIP and opening the discussion. I have a couple of initial questions/remarks: * The FLIP contains information for both Source and Sink, but nothing explicitly on the Lookup functionality. I'm assuming we also want to have that implementation covered while porting this to t

RE: Re: Re: Re: [DISCUSS] FLIP-239: Port JDBC Connector Source to FLIP-27

2022-07-01 Thread Roc Marshal
Hi, Weike. Thank you for your reply As you said, too many splits stored in SourceEnumerator will increase the load of JM. What do you think if we introduce a capacity of splits in SourceEnumerator to limit the total number, and introduce a reject or callback mechanism with too many splits in th

Re: Re: Re: [DISCUSS] FLIP-239: Port JDBC Connector Source to FLIP-27

2022-07-01 Thread Dong Weike
Hi, Thank you for bringing this up, and I am +1 for this feature. IMO, one important thing that I would like to mention is that an improperly-designed FLIP-27 connector could impose very severe memory pressure on the JobManager, especially when there are enormous number of splits for the sourc

RE: Re: Re: [DISCUSS] FLIP-239: Port JDBC Connector Source to FLIP-27

2022-06-30 Thread Roc Marshal
Hi, Lijie. Thanks for the catching and sorry for the typo in sorting out the draft. I updated it. Best regards, Roc Marshal On 2022/07/01 02:24:56 Lijie Wang wrote: > Hi Roc, > > Thanks for driving the discussion. > > Could you describe in detail what the JdbcSourceSplit represents? It loo