RE: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD

2024-12-12 Thread David Radley
Subject: [EXTERNAL] Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD Hi Ferenc Could you please help to create a FLIP page if everything looks fine from the above discussion/google doc. Thanks in advance. Regards Lajith K On Thu, Nov 7, 2024 at 12:02 PM Lajith Koova wrote: > Thank you

Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD

2024-11-27 Thread Lajith Koova
r committer to do this please; so we can get this >> moving. >> > >> > Kind regards, David. >> > >> > From: Lajith Koova lajith...@gmail.com >> > >> > Date: Monday, 14 October 2024 at 08:52 >> > To: dev@flink.apache.org dev@flin

Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD

2024-11-06 Thread Lajith Koova
> > > > Kind regards, David. > > > > From: Lajith Koova lajith...@gmail.com > > > > Date: Monday, 14 October 2024 at 08:52 > > To: dev@flink.apache.org dev@flink.apache.org > > > > Subject: [EXTERNAL] Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink >

RE: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD

2024-11-06 Thread Ferenc Csaky
ion mode.”. I am not sure I understand. > > > > > > * I thought we have 1 condition per Flink job state, so I assume we > > > have one true condition and potentially other historical false ones. > > > * When you say during transition, are you thinking of some

RE: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD

2024-11-06 Thread David Radley
over or get another committer to do this please; so we can get this moving. Kind regards, David. From: Lajith Koova Date: Monday, 14 October 2024 at 08:52 To: dev@flink.apache.org Subject: [EXTERNAL] Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD Thank you all for the valuable

Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD

2024-10-14 Thread Lajith Koova
dition and potentially other historical false ones. > > * When you say during transition, are you thinking of some small time > > window between states. I am not sure what you are saying here. > > > > > > Kind regards , David > > > > > &g

Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD

2024-09-24 Thread Lajith Koova
indow between states. I am not sure what you are saying here. > > > Kind regards , David > > > From: Lajith Koova > Date: Wednesday, 11 September 2024 at 03:01 > To: dev@flink.apache.org > Subject: [EXTERNAL] Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD > Hi,

Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD

2024-09-23 Thread Gyula Fóra
etween states. I am not sure what you are saying here. > > > Kind regards , David > > > From: Lajith Koova > Date: Wednesday, 11 September 2024 at 03:01 > To: dev@flink.apache.org > Subject: [EXTERNAL] Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD > Hi,

RE: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD

2024-09-23 Thread David Radley
gs from ResourceLifecycleState and with reasons). Can I >> > check that the 2 proposed conditions would also be useful additions? I >> > assume that in your proposal when jobReady is true, then >> UpgradeCompleted >> > condition would not be present and ClusterReady would

Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD

2024-06-06 Thread Lajith Koova
2 proposed conditions would also be useful additions? I > > assume that in your proposal when jobReady is true, then > UpgradeCompleted > > condition would not be present and ClusterReady would always be true? I > > know conditions do not need to be orthogonal, but I wanted to ch

Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD

2024-06-03 Thread Lajith Koova
related readiness condition related to it’s > > health would be useful; you suggest it be user configurable – this seems > > closer to a liveliness / readiness probe. > > > > Kind regards, David. > > > > From: Mate Czagany > > Date: Thursday, 30 May 2024 at 1

Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD

2024-06-02 Thread Thomas Weise
ems > closer to a liveliness / readiness probe. > > Kind regards, David. > > From: Mate Czagany > Date: Thursday, 30 May 2024 at 10:39 > To: dev@flink.apache.org > Cc: morh...@apache.org > Subject: [EXTERNAL] Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD > Hi, > &

RE: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD

2024-05-31 Thread David Radley
condition would not be present and ClusterReady would always be true? I > > know conditions do not need to be orthogonal, but I wanted to check what > > your thoughts are. > > > > Kind regards, David. > > > > > > > > > > From: Gyula Fóra > >

Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD

2024-05-30 Thread Mate Czagany
resent and ClusterReady would always be true? I > > know conditions do not need to be orthogonal, but I wanted to check what > > your thoughts are. > > > > Kind regards, David. > > > > > > > > > > From: Gyula Fóra > > Date: Wed

Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD

2024-05-30 Thread Gyula Fóra
t; > > > From: Gyula Fóra > Date: Wednesday, 29 May 2024 at 15:28 > To: dev@flink.apache.org > Cc: morh...@apache.org > Subject: [EXTERNAL] Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD > Hi David! > > This change definitely warrants a FLIP even if t

RE: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD

2024-05-29 Thread David Radley
thoughts are. Kind regards, David. From: Gyula Fóra Date: Wednesday, 29 May 2024 at 15:28 To: dev@flink.apache.org Cc: morh...@apache.org Subject: [EXTERNAL] Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD Hi David! This change definitely warrants a FLIP even if the code change is not

Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD

2024-05-29 Thread Gyula Fóra
Hi David! This change definitely warrants a FLIP even if the code change is not huge, there are quite some implications going forward. Looping in @morh...@apache.org for this discussion. I have some questions / suggestions regarding the condition's meaning and naming. In your proposal you have

Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD

2024-05-29 Thread David Radley
Hi, Thanks Lajith for raising this discussion thread under the Flip title. To summarise the concerns from the other discussion thread. “ - I echo Gyula that including some examples and further explanations might ease reader's work. With the current version, the FLIP is a bit hard to follow. - W