Let me clarify my suggestion: Let's put mandatory tags in the second
line of the commit message. That way, they can be filtered using git
log --grep=TAG and do not take away the first line's 80 characters.
On Wed, Jan 28, 2015 at 3:37 AM, Henry Saputra wrote:
> Just found out about this, thanks S
Just found out about this, thanks Stephan =)
- Henry
On Wed, Jan 7, 2015 at 7:44 AM, Stephan Ewen wrote:
> Hi all!
>
> Since the feedback was positive, I added the guidelines to the wiki, with a
> disclaimer that this is being refined.
>
> https://cwiki.apache.org/confluence/display/FLINK/Apache
I did not propose to pick the 5 most suitable tags. ;-)
Just to mark commits that break or extend the API.
If [api-breaking] and [api-extending] is considered to waste too much
space, I would also be happy with [api-] and [api+] (or any other
meaningful marker).
2015-01-28 2:37 GMT+01:00 Márton Ba
Originally I was going to support Fabian's suggestion - I still like it,
but I have to admit that it can become a slight overkill like in de8e066.
[1]
[1] https://git-wip-us.apache.org/repos/asf/flink/commit/de8e066
On Tue, Jan 27, 2015 at 2:03 PM, Max Michels wrote:
> I agree with Aljoscha. In
I agree with Aljoscha. Instead, I would suggest to make a tag in the
commit message mandatory. That way, you could list the associated
commits using git log --grep=api-breaking
On Tue, Jan 27, 2015 at 1:50 PM, Aljoscha Krettek wrote:
> But thats very long, and together with the issue tag I almost
But thats very long, and together with the issue tag I almost always
have I lose a lot of my precious 80 characters.
On Tue, Jan 27, 2015 at 1:17 PM, Fabian Hueske wrote:
> I know I argued against "enforcing" commit tags, but how about we make two
> tags mandatory, i.e., [api-breaking] and [api-
I know I argued against "enforcing" commit tags, but how about we make two
tags mandatory, i.e., [api-breaking] and [api-extending]?
2015-01-07 18:15 GMT+01:00 Gyula Fóra :
> +1
> This was much needed :)
> 2015.01.07. 18:10 ezt írta ("Max Michels" ):
>
> > Nice.
> >
> >
> > On Wed, Jan 7, 2015 at
