Re: Question: Flink JIRA issues for simple code comment improvements

2018-11-21 Thread Miguel Coimbra
Hello Till, it's a good point you are bringing up here. One of the reasons why there > are some irregularities is that the code has grown quite a bit over time. > Another is that we have established checkstyle rules but they are not yet > activated for all modules because the initial effort to fix

Re: Question: Flink JIRA issues for simple code comment improvements

2018-11-21 Thread Till Rohrmann
Hi Miguel, it's a good point you are bringing up here. One of the reasons why there are some irregularities is that the code has grown quite a bit over time. Another is that we have established checkstyle rules but they are not yet activated for all modules because the initial effort to fix all vi

Question: Flink JIRA issues for simple code comment improvements

2018-11-20 Thread Miguel Coimbra
Hello, I want to start contributing to the Apache Flink code base and have a question. While reading the code, I found small inconsistencies in the way comments are written (highly irrelevant but still noticeable) such as some function argument comments ending in a period while others do not, am