Re: Outer-join operator integration with DataSet API (FLINK-2576)

2015-09-03 Thread Fabian Hueske
Hi Johann, hi Ricky, Thanks for reaching out to the mailing list before taking action! I do also prefer option c. In principle, all inner join strategies can also be applied for all outer joins (for some hash strategies, a special HashTable implementation is required). I propose to add two method

Re: Outer-join operator integration with DataSet API (FLINK-2576)

2015-09-01 Thread Till Rohrmann
Hi Johann, I'd prefer 1.c, because the different join variants are semantically different and this should be IMO reflected in the API. Moreover, the `JoinHints` are used to give hints for the selection of the underlying strategy for the different join variants. For `leftOuterJoin` you could either

Outer-join operator integration with DataSet API (FLINK-2576)

2015-09-01 Thread Johann Kovacs
Hi all, we (Ricky and I) are currently working on the outer join implementation for Flink (FLINK-687, previous pull requests #907, #1052). I am now looking for advice on 2 issues specifically regarding the integration of the outer join operator with the DataSet API (FLINK-2576). 1. There are sev