Re: Looking for reviewer: FLINK-13127

2019-08-01 Thread Till Rohrmann
Thanks for the pointer. I'll take a look later today. Cheers, Till On Thu, Aug 1, 2019 at 8:00 AM David Morávek wrote: > Hi Till, the PR should be ready ;) Can you please do the final check? > > Best, > D. > > On Tue, Jul 23, 2019 at 3:01 PM Till Rohrmann > wrote: > > > I've assigned the issue

Re: Looking for reviewer: FLINK-13127

2019-07-31 Thread David Morávek
Hi Till, the PR should be ready ;) Can you please do the final check? Best, D. On Tue, Jul 23, 2019 at 3:01 PM Till Rohrmann wrote: > I've assigned the issue to you David. I think this feature makes sense. The > only question I have is why we need to sort the values. But let's discuss > the iss

Re: Looking for reviewer: FLINK-13127

2019-07-23 Thread Till Rohrmann
I've assigned the issue to you David. I think this feature makes sense. The only question I have is why we need to sort the values. But let's discuss the issue on the Github PR. @Tison and @Xintong, let me know once the PR is in mergeable state. Cheers, Till On Tue, Jul 23, 2019 at 4:14 AM Xinto

Re: Looking for reviewer: FLINK-13127

2019-07-22 Thread Xintong Song
David, Thank you for opening this PR. I also left a few comments. And I think we need a committer to assign this jira ticket to David. Maybe Till or any other committer could look into this? Thank you~ Xintong Song On Mon, Jul 22, 2019 at 8:37 PM Zili Chen wrote: > Hi David, > > Just revi

Re: Looking for reviewer: FLINK-13127

2019-07-22 Thread Zili Chen
Hi David, Just reviewed and left several comments. Thanks for your contribution! Best, tison. David Morávek 于2019年7月22日周一 下午5:59写道: > Hi, I've prepared a small patch related to Yarn deployment. Would anyone > please have a time to take a look at it? Thanks > > https://github.com/apache/flink/

Looking for reviewer: FLINK-13127

2019-07-22 Thread David Morávek
Hi, I've prepared a small patch related to Yarn deployment. Would anyone please have a time to take a look at it? Thanks https://github.com/apache/flink/pull/9022 Regards, D.