I guess with the upcoming 1.0 release there's heaps of more urgent things
on your plate, nevertheless just a quick update: I added a JIRA ticket [1]
and opened a PR [2] with the changes.
best regards
martin
[1] https://issues.apache.org/jira/browse/FLINK-3529
[2] https://github.com/apache/flink/
sure. will take that into account. Thanks for the input.
best regards
martin
Maximilian Michels schrieb am So., 21. Feb. 2016 um
13:49 Uhr:
> Hi Martin,
>
> Thanks for the proposal. This is a great idea and will help new
> contributors.
>
> How about having three sections and less check boxes?
Hi Martin,
Thanks for the proposal. This is a great idea and will help new contributors.
How about having three sections and less check boxes? I think checking
all those boxes will get announcing for regular contributors.
[ ] Pull Request
- JIRA issue associated
- Pull request only addresses
+1
On Fri, Feb 19, 2016 at 9:30 AM, Fabian Hueske wrote:
> Hi Martin,
>
> "mvn install" does include the goals "test" and "verify".
> In fact, "verify" is enough, because "install" does only copy the results
> into the local Maven repository (~/.m2/repository).
>
> So I think
> - [ ] Tests pass
Hi Martin,
"mvn install" does include the goals "test" and "verify".
In fact, "verify" is enough, because "install" does only copy the results
into the local Maven repository (~/.m2/repository).
So I think
- [ ] Tests pass (`mvn test`)
- [ ] Build passes (`mvn install`)
- [ ] Check style passe
Based on the recent discussion in the email thread 'Extending and improving
our "How to contribute" page', I propose to introduce the following
template for PRs
Thanks for contributing to Apache Flink, before you open your PR please
kindly take into consideration the following check list.
Onc
