Re: Guidance to new Flink developers

2019-02-26 Thread Feng LI
Hello Gordon, Dawid, Thanks for putting that pull request in 1.8 release and helping on the review. I'm still in observe mode on the list :) Tried not to chip in too early with new suggestions since they might have been proposed or already in the process. But here are my two cents: The things I

Re: Guidance to new Flink developers

2019-02-25 Thread Tzu-Li (Gordon) Tai
Hi Feng, Regarding your particular contribution: I think you did a good job in gathering consensus on how the fix should be addressed. The PR's changes also matches the original discussions, with good test coverage and quality all in all. The only thing lacking was more attention from reviewers t

Re: Guidance to new Flink developers

2019-02-25 Thread Dawid Wysakowicz
Hi Feng, Sorry to hear you feel that way. Our goal as a community is to make people as welcome as possible, but you must not forget we are only humans after all and we have limited capabilities ;) We always try to improve our processes, so if you have any suggestions what we could improve, feel f

Guidance to new Flink developers

2019-02-25 Thread Feng LI
Hello guys, Sorry if this is already discussed question, is there some guidance in place to help new Flink developers to integrate to the community ? I’m new to the community and super happy after submitting my first pull request ( https://github.com/apache/flink/pull/7726 ) after some discussion