Re: [VOTE] FLIP 87: Primary key constraints in Table API

2019-11-27 Thread Dawid Wysakowicz
Thanks all for the voting. I'm closing the vote now. So far, the votes received: * +1 votes (4 binding, 3 non-binding): - Kurt Young (binding) - Timo (binding) - Xingcan Cui (binding) - Jark Wu (binding) - Xuefu Z (non-binding) - Jingsong Li (non-binding) - Danny Chan (non-binding) * 0/-1 votes:

Re: FLIP 87: Primary key constraints in Table API

2019-11-24 Thread Danny Chan
Thanks for the work, Dawid, a big + 1 ! Best, Danny Chan 在 2019年11月22日 +0800 PM8:51,Dawid Wysakowicz ,写道: > Hi everyone, > > I would like to start a vote on FLIP-87. > > Please vote for the following design document: > > https://cwiki.apache.org/confluence/display/FLINK/FLIP+87%3A+Primary+key+cons

Re: FLIP 87: Primary key constraints in Table API

2019-11-24 Thread Jark Wu
+1 from my side. Best, Jark On Sat, 23 Nov 2019 at 16:04, Xingcan Cui wrote: > Thanks for driving this, Dawid. > > I’m +1 on it. > > One minor suggestion: I think it’s better to override the `equals()` and > `hashCode()` methods for `KeyConstraint`. > > Thanks, > Xingcan > > > On Nov 23, 2019,

Re: FLIP 87: Primary key constraints in Table API

2019-11-23 Thread Xingcan Cui
Thanks for driving this, Dawid. I’m +1 on it. One minor suggestion: I think it’s better to override the `equals()` and `hashCode()` methods for `KeyConstraint`. Thanks, Xingcan > On Nov 23, 2019, at 2:40 AM, Jingsong Li wrote: > > +1 thanks dawid for driving this. > > Best > Jingsong Lee >

Re: FLIP 87: Primary key constraints in Table API

2019-11-22 Thread Jingsong Li
+1 thanks dawid for driving this. Best Jingsong Lee Timo Walther : > +1 > > Thanks, > Timo > > > On 23.11.19 00:28, Xuefu Z wrote: > > +1 > > > > On Fri, Nov 22, 2019 at 5:31 AM Kurt Young wrote: > > > >> +1 > >> > >> Best, > >> Kurt > >> > >> > >> On Fri, Nov 22, 2019 at 8:51 PM Dawid Wysakowi

Re: FLIP 87: Primary key constraints in Table API

2019-11-22 Thread Timo Walther
+1 Thanks, Timo On 23.11.19 00:28, Xuefu Z wrote: +1 On Fri, Nov 22, 2019 at 5:31 AM Kurt Young wrote: +1 Best, Kurt On Fri, Nov 22, 2019 at 8:51 PM Dawid Wysakowicz wrote: Hi everyone, I would like to start a vote on FLIP-87. Please vote for the following design document: https:

Re: FLIP 87: Primary key constraints in Table API

2019-11-22 Thread Xuefu Z
+1 On Fri, Nov 22, 2019 at 5:31 AM Kurt Young wrote: > +1 > > Best, > Kurt > > > On Fri, Nov 22, 2019 at 8:51 PM Dawid Wysakowicz > wrote: > > > Hi everyone, > > > > I would like to start a vote on FLIP-87. > > > > Please vote for the following design document: > > > https://cwiki.apache.org/co

Re: FLIP 87: Primary key constraints in Table API

2019-11-22 Thread Kurt Young
+1 Best, Kurt On Fri, Nov 22, 2019 at 8:51 PM Dawid Wysakowicz wrote: > Hi everyone, > > I would like to start a vote on FLIP-87. > > Please vote for the following design document: > https://cwiki.apache.org/confluence/display/FLINK/FLIP+87%3A+Primary+key+constraints+in+Table+API > > The discu

FLIP 87: Primary key constraints in Table API

2019-11-22 Thread Dawid Wysakowicz
Hi everyone, I would like to start a vote on FLIP-87. Please vote for the following design document: https://cwiki.apache.org/confluence/display/FLINK/FLIP+87%3A+Primary+key+constraints+in+Table+API The discussion can be found at: http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/