Re: DataInputStream read vs. readFully

2016-09-28 Thread Maximilian Michels
Hi Ufuk, `read(buf)` is not always `read(buf, 0, buf.length)`. Whereas `readFully(buf)` ensures `read(buf, 0, buf.length)`, right? The method is clearly documented but these mistakes can happen like a forgotten null pointer check. If we want to prevent mistakes like this, we can replace `read(buf

DataInputStream read vs. readFully

2016-09-28 Thread Ufuk Celebi
Hey devs, had a quick discussion with Stephan about usage of DataInputStream read and readFully. In most cases we want to use readFully, but it's easy to accidentally use read instead (happened to me here for example: https://issues.apache.org/jira/browse/FLINK-4332), which only reads as many byte