Re: Contributing Code Guide - Clarification

2019-07-03 Thread Stephan Ewen
My personal take is the following: - These improvements are welcome in general. Improving code quality is a good idea. - At the same time, these refactorings can easily introduce new bugs - I would focus on issues where there is clearly duplication without need, but the code and refactoring

Contributing Code Guide - Clarification

2019-06-28 Thread Hugo Louro
Hi, I would like to ask if minor, focused, refactoring done by extracting duplicate code to private methods is welcome for existing code/classes. The reasoning behind my question is that I want to avoid [1], but at the same time I clearly identify with [2]. If it is indeed welcome, is it OK to com