Re: Code style guideline for Scala

2015-08-18 Thread Chiwan Park
Creating a JIRA issue [1] is done. Regards, Chiwan Park [1] https://issues.apache.org/jira/browse/FLINK-2539 > On Aug 18, 2015, at 5:28 PM, Till Rohrmann wrote: > > Good initiative Chiwan. +1 for a more unified code style. > > On Tue, Aug 18, 2015 at 10:25 AM, Chiwan Park wrote: > >> Okay,

Re: Code style guideline for Scala

2015-08-18 Thread Till Rohrmann
Good initiative Chiwan. +1 for a more unified code style. On Tue, Aug 18, 2015 at 10:25 AM, Chiwan Park wrote: > Okay, I’ll create a JIRA issue covered this topic. > > Regards, > Chiwan Park > > > On Aug 17, 2015, at 1:17 AM, Stephan Ewen wrote: > > > > +1 for formatting templates for Eclipse a

Re: Code style guideline for Scala

2015-08-18 Thread Chiwan Park
Okay, I’ll create a JIRA issue covered this topic. Regards, Chiwan Park > On Aug 17, 2015, at 1:17 AM, Stephan Ewen wrote: > > +1 for formatting templates for Eclipse and IntelliJ. > > On Sun, Aug 16, 2015 at 6:06 PM, Sachin Goel > wrote: > >> We should also write up a matching configuration

Re: Code style guideline for Scala

2015-08-16 Thread Stephan Ewen
+1 for formatting templates for Eclipse and IntelliJ. On Sun, Aug 16, 2015 at 6:06 PM, Sachin Goel wrote: > We should also write up a matching configuration file to be used in the > IDEs and provide it with the source. This might help in reducing any style > mistakes due to a reformat, which is

Re: Code style guideline for Scala

2015-08-16 Thread Sachin Goel
We should also write up a matching configuration file to be used in the IDEs and provide it with the source. This might help in reducing any style mistakes due to a reformat, which is actually very helpful with spaces around braces and operators. Especially with Scala, indentations and continuation

Re: Code style guideline for Scala

2015-08-16 Thread Stephan Ewen
Hi! I very much support that. A bit stricter rules in the style checkers lead to more uniform and better readable code. We can have stricter rules both in Java and Scala. Note that the hardest part of adding the style checks is actually adjusting all the existing code that violates the style. Th

Code style guideline for Scala

2015-08-16 Thread Chiwan Park
Hi All, I’m reviewing some pull requests written in Scala. While reviewing, I think that scala style checker is too loose and documentation about code style guideline in wiki [1] is poor. The code style for Scala doesn’t seems unified as that for Java. I suggest upgrading version of scalastyle