Got it. Thanks for detailed explanation.
On Fri, Jun 5, 2015 at 8:34 AM, Maximilian Michels wrote:
> Hi Lokesh,
>
> It depends. If you created the issue and submitted the pull request, then
> you are free to close the issue. A reviewer or another committer might
> actually mark the issue as reso
Hi Lokesh,
It depends. If you created the issue and submitted the pull request, then
you are free to close the issue. A reviewer or another committer might
actually mark the issue as resolved beforehand because he thinks that
everything is fixed. However, only the original reporter should close th
Thanks Marton.
On Fri, Jun 5, 2015 at 8:29 AM, Márton Balassi
wrote:
> Hey Lokesh,
>
> The implicit practice is that the committer merging you PR closes the JIRA.
> Please do not close the JIRA, before your patch is merged. If the committer
> forgets to close it after your code is in you are ver
Hey Lokesh,
The implicit practice is that the committer merging you PR closes the JIRA.
Please do not close the JIRA, before your patch is merged. If the committer
forgets to close it after your code is in you are very welcome to close it
yourself.
Best,
Marton
On Fri, Jun 5, 2015 at 5:24 PM, L
Hello,
Typically when a pull request is accepted for a JIRA issue, can I close the
JIRA or should I wait for pull request reviewer to close the issue. it's
done differently in various teams/projects. Just would like to know how
it's done here in Flink project so that I can follow for future pull
r
