I agree a pre-commit hook for these linting checks, should be available and
recommended in the developer documentation (I will put together a PR for this).
However, you can't enforce pre-commit hooks AFAIK so having something running
in CI would still help.
Tom Cooper
@tomcooper.dev | https://t
Hi Tom,
+1 to the idea. I would suggest pre-commit hooks be a good alternative as
they allow the developer to have more confidence before pushing the PR and
waiting for CI/CD to pick it up. Thoughts?
Regards,
Neelesh S. Salian
On Sat, Mar 29, 2025 at 00:19 Ferenc Csaky
wrote:
> Hi Tom,
>
> B
Hi Tom,
Big +1 for this. On a slightly different note, do we know why the
CI run is still in beta? I see that it currently fails because of
Python problems, but AFAIK it was not really touched for quite some
time.
Is it just needs some more development time, or we have resource
limitations, maybe
+1, this will save time for everyone.
On Fri, Mar 21, 2025 at 5:58 PM Tom Cooper wrote:
>
> Hey All,
>
> I wanted to start a discussion on enabling linting checks, via a GitHub
> Action, on all PRs in the main Flink repository.
>
> Often when a user submits a PR they will wait for the CI to run
Hey All,
I wanted to start a discussion on enabling linting checks, via a GitHub Action,
on all PRs in the main Flink repository.
Often when a user submits a PR they will wait for the CI to run in Azure DevOps
and this will fail as they have forgotten to run spotless or checkstyle.
However, in