Re: [reminder] Build and check the documentation when reviewing

2020-11-09 Thread Dian Fu
Thanks @Robert for this info. It seems that there is some problem with the "docs_404_check". From the log we can see that the doc server wasn't started up after 5 minutes and the test just exits. Have created a ticket https://issues.apache.org/jira/browse/FLINK-20069

Re: [reminder] Build and check the documentation when reviewing

2020-11-09 Thread Robert Metzger
Thank you Seth! @Dian: It is part of the nightly scheduled build: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=9361&view=logs&j=6dc02e5c-5865-5c6a-c6c5-92d598e3fc43 On Tue, Nov 10, 2020 at 2:50 AM Dian Fu wrote: > Thanks a lot for the reminder, Seth. > > What about int

Re: [reminder] Build and check the documentation when reviewing

2020-11-09 Thread Dian Fu
Thanks a lot for the reminder, Seth. What about integrating this script in the azure pipeline? There is a "Documentation links check" in travis before: https://travis-ci.org/github/apache/flink/jobs/742553633 Thanks, Dian > 在 2020年11月

Re: [reminder] Build and check the documentation when reviewing

2020-11-09 Thread Xintong Song
Thanks for the reminder, Seth. The `check_links.sh` script is helpful, and I was not aware of it. Do you think it makes sense to also mention the script in `flink-docs/README.md`? So that future developers could also be aware of it. Or is it already mentioned somewhere that I overlooked? Thank y

[reminder] Build and check the documentation when reviewing

2020-11-09 Thread Seth Wiesman
Hi Devs, First of all, I'd like to thank everyone for being more proactive about writing documentation along with their features. Compared to previous releases there is not so much last-minute documentation writing and that is something to be celebrated! That said, we are still beginning to see a