Re: [flink-shaded] Some suggestions for improvements

2017-07-24 Thread Chesnay Schepler
I've opened a PR to adjust the artifact names: https://github.com/apache/flink-shaded/pull/17 Under the new scheme the asm artifact would be named "flink-shaded-asm-5.0.4-1.0" By default maven concatenates the artifactId and version with a dash, hence no underscore. On 23.07.2017 21:37, St

Re: [flink-shaded] Some suggestions for improvements

2017-07-23 Thread Stephan Ewen
For the SNAPSHOT part, I do not feel too strong about that either, just a tendency to keep it in sync with how core Flink works. For the "tools" directory, we can keep it as it is. It seems to complicated and really is not a big deal... On Sun, Jul 23, 2017 at 8:31 PM, Chesnay Schepler wrote: >

Re: [flink-shaded] Some suggestions for improvements

2017-07-23 Thread Chesnay Schepler
I agree that the version scheme in the artifact isn't ideal. We can keep the tools out of the release, but not in a nice way. We either 1. remove it in a separate commit before each release 2. just omit it during the release process. 1) has the odd downside that the release branch cannot releas

[flink-shaded] Some suggestions for improvements

2017-07-23 Thread Stephan Ewen
A few comments what we can improve in future releases: - I agree with Robert's comment to change the versioning to the same model as Flink where the master branch is on a SNAPSHOT version always and the releases are branches/tags with stable versions. - The version names of the artifacts read