[RESULT][VOTE] Release flink-connector-gcp-pubsub v3.0.0, release candidate #1

2023-01-31 Thread Martijn Visser
I'm happy to announce that we have unanimously approved this release. There are 4 approving votes, 3 of which are binding: * Konstantin (binding) * Sergey (non-binding) * Danny (binding) * Martijn (binding) There are no disapproving votes. Thanks all! Best regards, Martijn

Re: [VOTE] Release flink-connector-gcp-pubsub v3.0.0, release candidate #1

2023-01-31 Thread Martijn Visser
I'm closing this vote and will announce the results in a separate email. Op di 31 jan. 2023 om 13:16 schreef Martijn Visser : > +1 (binding) > > Op di 31 jan. 2023 om 12:38 schreef Danny Cranmer >: > >> Thanks for the update. >> >> +1 (binding) >> >> >> On Tue, 31 Jan 2023, 11:11 Martijn Visser,

Re: [VOTE] Release flink-connector-gcp-pubsub v3.0.0, release candidate #1

2023-01-31 Thread Martijn Visser
+1 (binding) Op di 31 jan. 2023 om 12:38 schreef Danny Cranmer : > Thanks for the update. > > +1 (binding) > > > On Tue, 31 Jan 2023, 11:11 Martijn Visser, > wrote: > > > Hi Danny, > > > > > Why are we publishing the e2e tests jar? > > > > We shouldn't, but I think that's because the E2E tests c

Re: [VOTE] Release flink-connector-gcp-pubsub v3.0.0, release candidate #1

2023-01-31 Thread Danny Cranmer
Thanks for the update. +1 (binding) On Tue, 31 Jan 2023, 11:11 Martijn Visser, wrote: > Hi Danny, > > > Why are we publishing the e2e tests jar? > > We shouldn't, but I think that's because the E2E tests config for GCP > hasn't been changed since 2018 and don't reflect the new setup. I've > cr

Re: [VOTE] Release flink-connector-gcp-pubsub v3.0.0, release candidate #1

2023-01-31 Thread Martijn Visser
Hi Danny, > Why are we publishing the e2e tests jar? We shouldn't, but I think that's because the E2E tests config for GCP hasn't been changed since 2018 and don't reflect the new setup. I've created [1] as a follow-up. > When do we update to 2023? We should do that with the next release :) It'

Re: [VOTE] Release flink-connector-gcp-pubsub v3.0.0, release candidate #1

2023-01-27 Thread Danny Cranmer
Hey Martijn, thanks for driving yet another connector release. Before I cast my vote I have a couple of queries: * Contents of dist. Why are we publishing the e2e tests jar [1]? We do not typically do this, but I see the old GCP e2e tests are published [2], however not to maven central. * NOTICE a

Re: [VOTE] Release flink-connector-gcp-pubsub v3.0.0, release candidate #1

2023-01-26 Thread Sergey Nuyanzin
+1 (non-binding) * verified hashes and signatures * verified versions in pom files * verified LICENSE and NOTICE files * compared sources against git tag * built from sources On Thu, Jan 26, 2023 at 3:08 PM Konstantin Knauf wrote: > +1 (binding) > > * checked Maven and source artifact signatur

Re: [VOTE] Release flink-connector-gcp-pubsub v3.0.0, release candidate #1

2023-01-26 Thread Konstantin Knauf
+1 (binding) * checked Maven and source artifact signatures and checksums - OK * no binaries or packaged dependencies - OK * checked website changes - Approved. Am Fr., 20. Jan. 2023 um 15:39 Uhr schrieb Martijn Visser < martijnvis...@apache.org>: > Hi everyone, > Please review and vote on the r

[VOTE] Release flink-connector-gcp-pubsub v3.0.0, release candidate #1

2023-01-20 Thread Martijn Visser
Hi everyone, Please review and vote on the release candidate #1 for the version 3.0.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes [1], *