Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

2020-04-07 Thread godfrey he
Hi everyone, Thanks all for the votes. So far, we have - 3 binding +1 votes (Timo, Kurt, Dawid) - 1 non-binding +1 votes (Terry) - No -1 votes The voting time has past and there is enough +1 votes to consider the FLIP-84 approved. Thank you all. Best, Godfrey Dawid Wysakowicz 于2020年

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

2020-04-06 Thread Dawid Wysakowicz
+1 Best, Dawid On 07/04/2020 07:44, godfrey he wrote: > Hi, Kurt > > yes. `TableEnvironement#executeSql` also could execute `SELECT` statement, > which is similar to `Table#execute`. > I add this to the document. > > Best, > Godfrey > > Kurt Young 于2020年4月7日周二 上午11:52写道: > >> +1 (binding) >> >>

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

2020-04-06 Thread godfrey he
Hi, Kurt yes. `TableEnvironement#executeSql` also could execute `SELECT` statement, which is similar to `Table#execute`. I add this to the document. Best, Godfrey Kurt Young 于2020年4月7日周二 上午11:52写道: > +1 (binding) > > The latest doc looks good to me. One minor comment is with the latest > chang

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

2020-04-06 Thread Kurt Young
+1 (binding) The latest doc looks good to me. One minor comment is with the latest changes, it seems also very easy to support running SELECT query in TableEnvironement#executeSql method. Will this also be supported? Best, Kurt On Mon, Apr 6, 2020 at 10:49 PM Timo Walther wrote: > Thanks, for

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

2020-04-06 Thread Timo Walther
Thanks, for the update. +1 (binding) for this FLIP Regards, Timo On 06.04.20 16:47, godfrey he wrote: Hi Timo, Sorry for late reply, and thanks for your correction. I have fixed the typo and updated the document. Best, Godfrey Timo Walther 于2020年4月6日周一 下午6:05写道: Hi Godfrey, did you see

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

2020-04-06 Thread godfrey he
Hi Timo, Sorry for late reply, and thanks for your correction. I have fixed the typo and updated the document. Best, Godfrey Timo Walther 于2020年4月6日周一 下午6:05写道: > Hi Godfrey, > > did you see my remaining feedback in the discussion thread? We could > finish this FLIP if this gets resolved. > >

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

2020-04-06 Thread Timo Walther
Hi Godfrey, did you see my remaining feedback in the discussion thread? We could finish this FLIP if this gets resolved. Thanks, Timo On 03.04.20 15:12, Terry Wang wrote: +1 (non-binding) Looks great to me, Thanks for driving on this. Best, Terry Wang 2020年4月3日 21:07,godfrey he 写道: Hi

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

2020-04-03 Thread Terry Wang
+1 (non-binding) Looks great to me, Thanks for driving on this. Best, Terry Wang > 2020年4月3日 21:07,godfrey he 写道: > > Hi everyone, > > I'd like to start the vote of FLIP-84[1] again, which is discussed and > reached consensus in the discussion thread[2]. > > The vote will be open for at lea

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

2020-04-03 Thread godfrey he
Hi everyone, I'd like to start the vote of FLIP-84[1] again, which is discussed and reached consensus in the discussion thread[2]. The vote will be open for at least 72 hours. Unless there is an objection, I will try to close it by Apr 6, 2020 13:10 UTC if we have received sufficient votes. [1]

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

2020-03-31 Thread godfrey he
Hi, Timo So sorry about that, I'm in a little hurry. Let's wait for 24h. Best, Godfrey Timo Walther 于2020年3月31日周二 下午5:26写道: > -1 > > The current discussion has not completed. The last comments were sent > less than 24h ago. > > Let's wait a bit longer to collect feedback from all stakeholders.

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

2020-03-31 Thread Timo Walther
-1 The current discussion has not completed. The last comments were sent less than 24h ago. Let's wait a bit longer to collect feedback from all stakeholders. Thanks, Timo On 31.03.20 08:31, godfrey he wrote: Hi everyone, I'd like to start the vote of FLIP-84[1] again, because we have some

[VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

2020-03-30 Thread godfrey he
Hi everyone, I'd like to start the vote of FLIP-84[1] again, because we have some feedbacks. The feedbacks are all about new introduced methods, here is the discussion thread [2]. The vote will be open for at least 72 hours. Unless there is an objection, I will try to close it by Apr 3, 2020 06:3

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment

2020-03-01 Thread godfrey he
Thanks all for the votes. So far, we have - 3 binding +1 votes (Kurt, Jark, Jingsong) - 2 non-binding +1 votes (Terry, Benchao) - No -1 votes The voting time has past and there is enough +1 votes to consider the FLIP-84 approved. Thank you all. Best, Godfrey godfrey he 于2020年3月2日周一 下

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment

2020-03-01 Thread godfrey he
Thanks Jingsong for the reminding. I will update it now. Jingsong Lee 于2020年3月2日周一 下午2:46写道: > Thanks for driving. > > +1 from my side. > > > For current messy Flink table program trigger point, we propose that: for > TableEnvironment and StreamTableEnvironment, you must use > `TableEnvironment.

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment

2020-03-01 Thread Jingsong Lee
Thanks for driving. +1 from my side. > For current messy Flink table program trigger point, we propose that: for TableEnvironment and StreamTableEnvironment, you must use `TableEnvironment.execute()` to trigger table program execution. Looks like this is an incompatible change. You need update C

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment

2020-02-28 Thread Benchao Li
+1 (non-binding) Jark Wu 于2020年2月28日周五 下午5:11写道: > +1 from my side. > > Best, > Jark > > On Fri, 28 Feb 2020 at 15:07, kant kodali wrote: > > > Nice!! > > > > Sent from my iPhone > > > > > On Feb 27, 2020, at 9:03 PM, godfrey he wrote: > > > > > > Hi kant, yes. We hope to deprecate the method

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment

2020-02-28 Thread Jark Wu
+1 from my side. Best, Jark On Fri, 28 Feb 2020 at 15:07, kant kodali wrote: > Nice!! > > Sent from my iPhone > > > On Feb 27, 2020, at 9:03 PM, godfrey he wrote: > > > > Hi kant, yes. We hope to deprecate the methods which confuse users ASAP. > > > > Bests, > > godfrey > > > > kant kodali 于

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment

2020-02-27 Thread kant kodali
Nice!! Sent from my iPhone > On Feb 27, 2020, at 9:03 PM, godfrey he wrote: > > Hi kant, yes. We hope to deprecate the methods which confuse users ASAP. > > Bests, > godfrey > > kant kodali 于2020年2月28日周五 上午11:17写道: > >> Is this targeted towards Flink 1.11? >> >>> On Thu, Feb 27, 2020 at 6

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment

2020-02-27 Thread godfrey he
Hi kant, yes. We hope to deprecate the methods which confuse users ASAP. Bests, godfrey kant kodali 于2020年2月28日周五 上午11:17写道: > Is this targeted towards Flink 1.11? > > On Thu, Feb 27, 2020 at 6:32 PM Kurt Young wrote: > > > +1 (binding) > > > > Best, > > Kurt > > > > > > On Fri, Feb 28, 2020

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment

2020-02-27 Thread kant kodali
Is this targeted towards Flink 1.11? On Thu, Feb 27, 2020 at 6:32 PM Kurt Young wrote: > +1 (binding) > > Best, > Kurt > > > On Fri, Feb 28, 2020 at 9:15 AM Terry Wang wrote: > > > I look through the whole design and it’s a big improvement of usability > on > > TableEnvironment’s api. > > > >

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment

2020-02-27 Thread Kurt Young
+1 (binding) Best, Kurt On Fri, Feb 28, 2020 at 9:15 AM Terry Wang wrote: > I look through the whole design and it’s a big improvement of usability on > TableEnvironment’s api. > > +1 (non-binding) > > Best, > Terry Wang > > > > > 2020年2月27日 14:59,godfrey he 写道: > > > > Hi everyone, > > > >

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment

2020-02-27 Thread Terry Wang
I look through the whole design and it’s a big improvement of usability on TableEnvironment’s api. +1 (non-binding) Best, Terry Wang > 2020年2月27日 14:59,godfrey he 写道: > > Hi everyone, > > I'd like to start the vote of FLIP-84[1], which proposes to deprecate some > old APIs and introduce so

[VOTE] FLIP-84: Improve & Refactor API of TableEnvironment

2020-02-26 Thread godfrey he
Hi everyone, I'd like to start the vote of FLIP-84[1], which proposes to deprecate some old APIs and introduce some new APIs in TableEnvironment. This FLIP is discussed and reached consensus in the discussion thread[2]. The vote will be open for at least 72 hours. Unless there is an objection, I