+1
Dawid Wysakowicz 于2019年8月30日周五 下午7:34写道：
> +1 to the design
>
> On 29/08/2019 15:53, Timo Walther wrote:
> > I converted the mentioned Google doc into a wiki page:
> >
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-54%3A+Evolve+ConfigOption+and+Configuration
> >
> >
> > The core
+1 to the design
On 29/08/2019 15:53, Timo Walther wrote:
> I converted the mentioned Google doc into a wiki page:
>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-54%3A+Evolve+ConfigOption+and+Configuration
>
>
> The core semantics have not changed.
>
> Happy voting,
> Timo
>
> On 29.08
I converted the mentioned Google doc into a wiki page:
https://cwiki.apache.org/confluence/display/FLINK/FLIP-54%3A+Evolve+ConfigOption+and+Configuration
The core semantics have not changed.
Happy voting,
Timo
On 29.08.19 04:30, Zili Chen wrote:
The design looks good to me.
+1 go ahead!
Bes
The design looks good to me.
+1 go ahead!
Best,
tison.
Jark Wu 于2019年8月28日周三 下午6:08写道：
> Hi Timo,
>
> The new changes looks good to me.
>
> +1 to the FLIP.
>
>
> Cheers,
> Jark
>
> On Wed, 28 Aug 2019 at 16:02, Timo Walther wrote:
>
> > Hi everyone,
> >
> > after some last minute changes yes
Hi Timo,
The new changes looks good to me.
+1 to the FLIP.
Cheers,
Jark
On Wed, 28 Aug 2019 at 16:02, Timo Walther wrote:
> Hi everyone,
>
> after some last minute changes yesterday, I would like to start a new
> vote on FLIP-54. The discussion seems to have reached an agreement. Of
> course
Hi everyone,
after some last minute changes yesterday, I would like to start a new
vote on FLIP-54. The discussion seems to have reached an agreement. Of
course this doesn't mean that we can't propose further improvements on
ConfigOption's and Flink configuration in general in the future. It i
Hi Dawid,
I'm a big fan of immutability and your suggestion makes sense to me.
Furthermore, I thought about the class name clashes of ConfigOptionGroup
and the existing ConfigGroup annotation. Maybe we should come up with a
better name.
I will make some additional adjustments to the FLIP. I
Actually I wanted to propose a slight change to the proposal. Therefore
I want to change my vote to -1 for now.
I suggest to change the Configurable interface to ConfigurableFactory:
public interface ConfigurableFactory {
/**
* Creates an instance from the given configuration.
*/
+1 non-binding
Best,
Jingsong Lee
--
From:Dawid Wysakowicz
Send Time:2019年8月27日(星期二) 13:55
To:dev ; Timo Walther
Subject:Re: [VOTE] FLIP-54: Evolve ConfigOption and Configuration
+1 to the FLIP
Also I think we should mention
+1 to the FLIP
Also I think we should mention that the voting will last at least 72
hours as requested by the bylaws until 30 Aug 14:00 CEST. (Correct me if
I am wrong Timo)
On 27/08/2019 13:32, Jark Wu wrote:
> +1 to the FLIP.
>
>
> Regards,
> Jark
>
>> 在 2019年8月27日，19:28，Timo Walther 写道：
>>
>>
+1 to the FLIP.
Regards,
Jark
> 在 2019年8月27日，19:28，Timo Walther 写道：
>
> Hi everyone,
>
> thanks for the great feedback we have received for the draft of FLIP-54. The
> discussion seems to have reached an agreement. Of course this doesn't mean
> that we can't propose further improvements on
Hi everyone,
thanks for the great feedback we have received for the draft of FLIP-54.
The discussion seems to have reached an agreement. Of course this
doesn't mean that we can't propose further improvements on
ConfigOption's and Flink configuration in general in the future. It is
just one st
12 matches
Mail list logo
