Re: [VOTE] FLIP-33: Standardize connector metrics

2020-09-27 Thread Becket Qin
Hi all, Thanks everyone for voting. Here is the result: binding +1s: 4 (Stephan, Yu, Jincheng, Becket) There is no -1 or non-binding +1s. FLIP-33 has been accepted. Thanks, Jiangjie (Becket) Qin On Sun, Sep 27, 2020 at 7:18 PM Stephan Ewen wrote: > +1 > > On Mon, Sep 21, 2020 at 11:48 AM Yu

Re: [VOTE] FLIP-33: Standardize connector metrics

2020-09-27 Thread Stephan Ewen
+1 On Mon, Sep 21, 2020 at 11:48 AM Yu Li wrote: > +1 > > I could see this is a well written document after a long and thorough > discussion [1]. Thanks for driving this all along, Becket! > > Best Regards, > Yu > > [1] > > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-F

Re: [VOTE] FLIP-33: Standardize connector metrics

2020-09-21 Thread Yu Li
+1 I could see this is a well written document after a long and thorough discussion [1]. Thanks for driving this all along, Becket! Best Regards, Yu [1] http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-33-Standardize-connector-metrics-td26869.html On Mon, 21 Sep 2020

Re: [VOTE] FLIP-33: Standardize connector metrics

2020-09-21 Thread jincheng sun
+1， Thanks for driving this, Becket! Best, Jincheng Becket Qin 于2020年9月21日周一 上午11:31写道： > Hi all, > > I would like to start the voting thread for FLIP-33 which proposes to > standardize the metrics of Flink connectors. > > In short, we would like to provide a convention and guidance of Flink >

Re: [VOTE] FLIP-33: Standardize connector metrics

2020-09-21 Thread Yuan Mei
+1 On Mon, Sep 21, 2020 at 11:31 AM Becket Qin wrote: > Hi all, > > I would like to start the voting thread for FLIP-33 which proposes to > standardize the metrics of Flink connectors. > > In short, we would like to provide a convention and guidance of Flink > connector metrics. It will help sim

[VOTE] FLIP-33: Standardize connector metrics

2020-09-20 Thread Becket Qin
Hi all, I would like to start the voting thread for FLIP-33 which proposes to standardize the metrics of Flink connectors. In short, we would like to provide a convention and guidance of Flink connector metrics. It will help simplify the monitoring and alerting on Flink jobs. The FLIP link is fol

Re: [VOTE] FLIP-33: Standardize connector metrics

2019-06-13 Thread Becket Qin
Hi Chesnay and Piotr, Thanks for the reply. I have updated the wiki page to change rate metric name from "PerSec" to "PerSecond". And yes, the I/O metrics are sort of standardized across all the operators, and probably for all the connectors in Flink as well. The reason I included them into the c

Re: [VOTE] FLIP-33: Standardize connector metrics

2019-06-13 Thread Piotr Nowojski
+1 from my side % Chesnay’s comment. Piotrek > On 13 Jun 2019, at 09:35, Chesnay Schepler wrote: > > The rate metrics should end in "PerSecond" instead of "PerSec" to be > consistent with existing metrics. > > I'm a bit unsure whether it makes send to include the In/Out metrics in this > pro

Re: [VOTE] FLIP-33: Standardize connector metrics

2019-06-13 Thread Chesnay Schepler
The rate metrics should end in "PerSecond" instead of "PerSec" to be consistent with existing metrics. I'm a bit unsure whether it makes send to include the In/Out metrics in this proposal, given that these metrics are standardized across all operators already (at least in terms of _/existing/

[VOTE] FLIP-33: Standardize connector metrics

2019-06-12 Thread Becket Qin
Hi Flink devs, I would like to start the voting for FLIP-33 which aims to standardize connector metrics. FLIP wiki: https://cwiki.apache.org/confluence/display/FLINK/FLIP-33%3A+Standardize+Connector+Metrics Discussion thread: https://lists.apache.org/thread.html/65078bad6e047578d502e1e5d9202