Re: [VOTE] FLIP-284: Making AsyncSinkWriter Flush triggers adjustable

2023-03-28 Thread Samrat Deb
Thank you Ahmed for driving the change. This new feature will help flink developers with more control on their job in SinkWriter. +1 (non binding) Bests, Samrat On Mon, Mar 27, 2023 at 12:34 PM Danny Cranmer wrote: > Thanks for driving this Ahmed. This change will benefit future and current

Re: [VOTE] FLIP-284: Making AsyncSinkWriter Flush triggers adjustable

2023-03-27 Thread Danny Cranmer
Thanks for driving this Ahmed. This change will benefit future and current sink implementations by giving the developer more flexibility. A good addition following configurable rate limiting strategies [1]. +1 (binding) Thanks, Danny [1] https://cwiki.apache.org/confluence/display/FLINK/FLIP-242

[VOTE] FLIP-284: Making AsyncSinkWriter Flush triggers adjustable

2023-03-26 Thread Ahmed Hamdy
Dear Flink developers, I want to move discussion on this FLIP[1] to voting. Discussion thread[2] has been inactive for more than 2 months. Please feel free to add your feedback below. The vote will be open for at least 72 hours unless there is an objection or not enough votes. [1] https://cwiki.