Hi all,
I’m happy to announce we have unanimously approved this proposal, with 4
binding votes and 5 non-binding votes.
+1 votes:
* Danny (binding)
* Jing (non-binding)
* Ahmed (non-binding)
* Yuxia (non-binding)
* Martijn (binding)
* Matthias (binding)
* Samrat (non-binding)
* Daren (non-bindin
"
Cc: "Teoh, Hong" , Chesnay Schepler
Subject: RE: [EXTERNAL][VOTE] Externalize AWS formats to flink-connector-aws
CAUTION: This email originated from outside of the organization. Do not click
links or open attachments unless you can confirm the sender and know the
content is safe.
Got it. Thanks for flagging it up.
I have created a JIRA for the followup to make flink-avro Public API more
clear. https://issues.apache.org/jira/browse/FLINK-30853
Will close this vote thread and announce in a separate thread.
Regards,
Hong
Hi all,
It seems that we are on the same page that having flink-connector-aws use
non-public API from apache/flink is not a blocking issue here. And I agree
that it would be nice to make necessary APIs public so that 1) projects
outside Flink can also develop similar connectors and 2)
flink-connec
I don't intend to block this FLIP, but just wanted to raise awareness of
the issue and it's implications.
Ultimately in the worst case more connector-aws releases will have to be
made if the API is changed in an incompatible-way.
Whether this risk is acceptable is something you will have to d
Hi @Dong Lin @Chesnay Schepler,
We have deviated from the original purpose of this thread.
Let's keep this thread to the original proposal of externalising
flink-avro-glue-schema-registry and flink-json-glue-schema-registry formats to
the flink-connector-aws repository.
The way I see it, @Che
> Existing APIs in Flink which are marked with @Internal also don't
offer any compatibility guarantee. Yet we are OK to have classes in
Flink use them.
Well of course, it's the same codebase. If we change the API we can
change all usages as well. Hence, there's no problem using internal APIs.
Hello all,
@Dong Lin while I agree with your reasoning here, our ultimate aim is to
have stable public APIs. If we need to use @Internal apis for the Apache
connectors/formats/etc, then it is likely that users building custom
integrations do too. Therefore I am aligned with @Chesnay that we should
Hi Hong,
Thanks for the detailed reply.
It seems that there are roughly 32 public classes in flink-avro that are
not marked with @PublicEvolving. Some of them are explicitly marked
as @Internal. Are you suggesting to mark all these classes as
@PublicEvolving?
I agree it would be nice to mark mor
On Mon, Jan 30, 2023 at 8:51 PM Chesnay Schepler wrote:
> On 30/01/2023 13:24, Dong Lin wrote:
> > it should be OK for
> > apache/flink-connector-aws to use non-public API, similar to how classes
> > inside Flink can use APIs marked with @Internal.
> >
> > We can mark related classes with @Intern
Hi @Chesnay @Dong Lin,
Thanks for flagging up the concerns.
I agree that we should make clear which APIs are public in flink-avro so that
we can make the connector code more independent. IMO that moves in the right
direction for Flink in general!
1. Public classes/interfaces in flink-avro
-
On 30/01/2023 13:24, Dong Lin wrote:
it should be OK for
apache/flink-connector-aws to use non-public API, similar to how classes
inside Flink can use APIs marked with @Internal.
We can mark related classes with @Internal as appropriate, without
requiring any new FLIP.
It's not though, because
Thanks Hong for driving this effort!
+1 (binding)
Regarding the concern mentioned by Chesnay, since
apache/flink-connector-aws is managed by Flink community (not by Flink
users) similar to the apache/flink, it should be OK for
apache/flink-connector-aws to use non-public API, similar to how class
件人: "dev"
发送时间: 星期一, 2023年 1 月 30日 下午 4:01:14
主题: Re: [VOTE] Externalize AWS formats to flink-connector-aws
+1 (non-binding)
Thanks,
Ahmed
On Fri, 27 Jan 2023 at 17:24, Jing Ge wrote:
+1 Thanks for driving it!
Best regards,
Jing
On Fri, Jan 27, 2023 at 2:36 PM Danny Cranmer
wrote:
> > > 发件人: "Ahmed Hamdy"
> > > 收件人: "dev"
> > > 发送时间: 星期一, 2023年 1 月 30日 下午 4:01:14
> > > 主题: Re: [VOTE] Externalize AWS formats to flink-connector-aws
> > >
> > > +1 (non-binding)
> > >
chreef yuxia
> >
> > > +1 (non-binding).
> > > Thanks for driving it.
> > >
> > > Best regards,
> > > Yuxia
> > >
> > > - 原始邮件 -----
> > > 发件人: "Ahmed Hamdy"
> > > 收件人: "dev"
>
> - 原始邮件 -
> > 发件人: "Ahmed Hamdy"
> > 收件人: "dev"
> > 发送时间: 星期一, 2023年 1 月 30日 下午 4:01:14
> > 主题: Re: [VOTE] Externalize AWS formats to flink-connector-aws
> >
> > +1 (non-binding)
> > Thanks,
> > Ahmed
> &
+1 (binding)
Op ma 30 jan. 2023 om 09:30 schreef yuxia
> +1 (non-binding).
> Thanks for driving it.
>
> Best regards,
> Yuxia
>
> - 原始邮件 -
> 发件人: "Ahmed Hamdy"
> 收件人: "dev"
> 发送时间: 星期一, 2023年 1 月 30日 下午 4:01:14
> 主题: Re: [VOTE]
+1 (non-binding).
Thanks for driving it.
Best regards,
Yuxia
- 原始邮件 -
发件人: "Ahmed Hamdy"
收件人: "dev"
发送时间: 星期一, 2023年 1 月 30日 下午 4:01:14
主题: Re: [VOTE] Externalize AWS formats to flink-connector-aws
+1 (non-binding)
Thanks,
Ahmed
On Fri, 27 Jan 2023 at 17:24, J
+1 (non-binding)
Thanks,
Ahmed
On Fri, 27 Jan 2023 at 17:24, Jing Ge wrote:
> +1 Thanks for driving it!
>
> Best regards,
> Jing
>
> On Fri, Jan 27, 2023 at 2:36 PM Danny Cranmer
> wrote:
>
> > Hello Hong, thanks for driving this.
> >
> > +1 on the proposal and the voting schema looks good.
> >
+1 Thanks for driving it!
Best regards,
Jing
On Fri, Jan 27, 2023 at 2:36 PM Danny Cranmer
wrote:
> Hello Hong, thanks for driving this.
>
> +1 on the proposal and the voting schema looks good.
>
> Thanks
>
> On Thu, Jan 26, 2023 at 5:15 PM Teoh, Hong
> wrote:
>
> > Hi all,
> >
> > As discusse
Hello Hong, thanks for driving this.
+1 on the proposal and the voting schema looks good.
Thanks
On Thu, Jan 26, 2023 at 5:15 PM Teoh, Hong
wrote:
> Hi all,
>
> As discussed in the discussion thread [1], I would like to propose we
> externalize flink-avro-glue-schema-registry and
> flink-json-
Hi all,
As discussed in the discussion thread [1], I would like to propose we
externalize flink-avro-glue-schema-registry and flink-json-glue-schema-registry
formats to the flink-connector-aws repository [2].
Motivation:
1. We can unify and upgrade the AWS SDK versions more easily.
2. We can no
23 matches
Mail list logo
