Thanks for your suggestions and information.
I'll therefore reopen the corresponding pull request.
Best,
tison.
Till Rohrmann 于2019年9月18日周三 下午10:55写道：
> No reason to keep the separation. The NewClusterClient interface was only
> introduced to add new methods and not having to implement them f
No reason to keep the separation. The NewClusterClient interface was only
introduced to add new methods and not having to implement them for the
other ClusterClient implementations.
Cheers,
Till
On Wed, Sep 18, 2019 at 3:17 PM Aljoscha Krettek
wrote:
> I agree that NewClusterClient and ClusterC
I agree that NewClusterClient and ClusterClient can be merged now that there is
no pre-FLIP-6 code base anymore.
Side note, there are a lot of methods in ClusterClient that should not really
be there, in my opinion:
- all the getOptimizedPlan*() method
- the run() methods. In the end, only sub
Hi Xiaogang,
Thanks for your reply.
According to the feature discussion thread[1] client API enhancement is a
planned
feature towards 1.10 and thus I think this thread is valid if we can reach
a consensus
and introduce new client API in this development cycle.
Best,
tison.
[1]
https://lists.apa
Hi Tison,
Thanks for bringing this.
I think it's fine to break the back compatibility of client API now that
ClusterClient is not well designed for public usage.
But from my perspective, we should postpone any modification to existing
interfaces until we come to an agreement on new client API. Ot
Hi Jeff,
Thanks for your reply.
The ongoing client API enhancement thread[1] is mainly aimed at dealing with
issues of our client API, as you mentioned, current client API is no so
clean.
Because client API naturally becomes public & user-facing inteface it is
expected that we start a series of
Thanks for raising this discussion. Overall +1 to merge NewClusterClient
into ClusterClient.
1. I think it is OK to break the backward compatibility. This current
client api is no so clean which already cause issue for downstream project
and flink itself.
In flink scala shell, I notice this kind o
Hi devs,
FLINK-14096[1] was created yesterday. It is aimed at merge the bridge
class NewClusterClient into ClusterClient because with the effort
under FLINK-10392 this bridge class is no longer necessary.
Technically in current codebase all implementation of interface
NewClusterClient is subclass
