Re: [PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-20 Thread Stephan Ewen
ter. > > > >> > > > > > >> > > From my experience this will benefit on both contributors and > > > >> reviewers > > > >> > > side! Thus +1 for putting into practice as well. > > > >> > > > > > >

Re: [PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-20 Thread 陈梓立
gt; > > >> > > On Mon, Sep 17, 2018 at 10:18 AM Stephan Ewen > > >> wrote: > > >> > > > > >> > > > Hi! > > >> > > > > > >> > > > Thanks you for the encouraging feedback so far. >

Re: [PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-19 Thread Thomas Weise
> > > get fewer pull requests that are disregarded. > >> > > > > >> > > > There are various reasons for the disregarded pull requests, one > >> being > >> > > that > >> > > > fewer committers really participate in re

Re: [PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-19 Thread 陈梓立
ven pull request requires document, its owner might no > add > > > it > > > >>> at > > > >>>> first. The PR template is a guide but not which one have to learn. > > > >>>> > > > >>>> To sum up, (1) take advantage

Re: [PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-19 Thread Fabian Hueske
>> > > >>>> Rong Rong 于2018年9月18日周二 上午7:05写道: > > >>>> > > >>>>> Thanks for putting the review contribution doc together, Stephan! > > This > > >>>> will > > >>>>> definitely help the community

Re: [PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-19 Thread 陈梓立
;> > >>>>> On Mon, Sep 17, 2018 at 10:18 AM Stephan Ewen > >>> wrote: > >>>>> > >>>>>> Hi! > >>>>>> > >>>>>> Thanks you for the encouraging feedback so far. > >>>>>>

Re: [PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-19 Thread Piotr Nowojski
eedback so far. >>>>>> >>>>>> The overall goal is definitely to make the contribution process >>> better >>>>> and >>>>>> get fewer pull requests that are disregarded. >>>>>> >>>>>> Th

Re: [PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-18 Thread 陈梓立
t;> > > > >> > > > The other reason I was lack of structure and lack of decision >> making, >> > > which >> > > > is what I am first trying to fix here. >> > > > A follow-up to this will definitely be to improve the contribution

Re: [PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-18 Thread 陈梓立
e contribution > > guide > > > as > > > > well. > > > > > > > > Best, > > > > Stephan > > > > > > > > > > > > On Mon, Sep 17, 2018 at 12:05 PM, Zhijiang(wangzhijiang999) < > > > > wangzhijia

Re: [PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-18 Thread Stephan Ewen
contirbuting or reviewing than before, although > we > > > > still have some points for further progress. > > > > > > > > I reviewed the proposal doc, and it gives very constructive and > > > meaningful > > > > guides which could help bot

Re: [PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-17 Thread 陈梓立
an before, although we > > > still have some points for further progress. > > > > > > I reviewed the proposal doc, and it gives very constructive and > > meaningful > > > guides which could help both contributor and reviewer. I agree with the > &g

Re: [PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-17 Thread Rong Rong
ves very constructive and > meaningful > > guides which could help both contributor and reviewer. I agree with the > > bove suggestions and wish they can be praticed well! > > > > Best, > > Zhijiang > > -------------------------

Re: [PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-17 Thread Stephan Ewen
well! > > Best, > Zhijiang > -- > 发件人:Till Rohrmann > 发送时间:2018年9月17日(星期一) 16:27 > 收件人:dev > 主 题:Re: [PROPOSAL] [community] A more structured approach to reviews and > contributions > > Thanks for writing this u

回复:[PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-17 Thread Zhijiang(wangzhijiang999)
contributor and reviewer. I agree with the bove suggestions and wish they can be praticed well! Best, Zhijiang -- 发件人:Till Rohrmann 发送时间:2018年9月17日(星期一) 16:27 收件人:dev 主 题:Re: [PROPOSAL] [community] A more structured approach to reviews

Re: [PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-17 Thread 陈梓立
Hi Stephan, Thanks for raising this discussion and the previous work! I strongly support effort to improve the process of contributions and reviews. As you mentioned above, Flink community responses to contributions a bit inefficiently, both for latency and quality. In my opinion the most import

Re: [PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-17 Thread Till Rohrmann
Thanks for writing this up Stephan. I like the steps and hope that it will help the community to make the review process better. Thus, +1 for putting your proposal to practice. Cheers, Till On Mon, Sep 17, 2018 at 10:00 AM Stephan Ewen wrote: > Hi Flink community members! > > As many of you wil

[PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-17 Thread Stephan Ewen
Hi Flink community members! As many of you will have noticed, the Flink project activity has gone up again quite a bit. There are many more contributions, which is an absolutely great thing to have :-) However, we see a continuously growing backlog of pull requests and JIRA issues. To make sure t