Re: [Discuss][Flink-31326] Flink autoscaler code

We discussed in the PR that it's actually a feature, but thanks Yang for bringing it up and improving the docs around this piece of code! -Max On Tue, Jan 2, 2024 at 10:06 PM Yang LI wrote: > > Hello Rui, > > Here is the jira ticket https://issues.apache.org/jira/browse/FLINK-33966, I > have pu

Re: [Discuss][Flink-31326] Flink autoscaler code

Hello Rui, Here is the jira ticket https://issues.apache.org/jira/browse/FLINK-33966, I have pushed a tiny pr for this ticket. Regards, Yang On Tue, 2 Jan 2024 at 16:15, Rui Fan <1996fan...@gmail.com> wrote: > Thanks Yang for report

Re: [Discuss][Flink-31326] Flink autoscaler code

Thanks Yang for reporting this issue! You are right, these 2 conditions are indeed the same. It's unexpected IIUC. Would you like to fix it? Feel free to create a FLINK JIRA to fix it if you would like to, and I'm happy to review! And cc @Maximilian Michels Best, Rui On Tue, Jan 2, 2024 at 11

[Discuss][Flink-31326] Flink autoscaler code

Hello, I see we have 2 times the same condition check in the function getNumRecordsInPerSecond (L220 and L224