Re: [Discuss]: Adding Metrics to StreamingFileSink

2019-05-17 Thread Till Rohrmann
I think you are right that some connectors will still need some special metrics due to their peculiarities. I guess that this won't be addressed with the FLIP but it could be a starting point. Cheers, Till On Fri, May 17, 2019 at 8:26 AM Kailash Dayanand wrote: > Hello Till, > > Thanks a lot f

Re: [Discuss]: Adding Metrics to StreamingFileSink

2019-05-16 Thread Kailash Dayanand
Hello Till, Thanks a lot for the information. It makes a lot of sense to have generic sink based metrics. Some things which maybe useful for file system sinks is the number of files written as well. I am assuming that will be abstracted under number of records for something like a bulk writer ( mu

Re: [Discuss]: Adding Metrics to StreamingFileSink

2019-05-16 Thread Till Rohrmann
Hi Kailash, have you seen FLIP-33 [1] and the corresponding ML thread [2]. The scope of this improvement proposal is to extend the set of standard metrics a connector should offer. Maybe this can already solve your problem. Concerning your second proposal for the StreamingFileSink, I think this s

Re: [Discuss]: Adding Metrics to StreamingFileSink

2019-05-15 Thread Thomas Weise
+1 to both suggestions It should be possible to extend the connector (we run into the same issues with KinesisConsumer). Metrics are essential to understand the performance, especially for things like S3 writes, error, retries, memory buffers and so on. Thomas On 2019/05/15 07:43:39, Kailash

[Discuss]: Adding Metrics to StreamingFileSink

2019-05-15 Thread Kailash Dayanand
Hello, I was looking to add metrics to the streaming file sink. Currently the only details available is the generic information about for any operator like the number of records in, number of records out etc. I was looking at adding some metrics and contributing back as well as enabling the metric