Re: [DISCUSSION] test connectors against Flink master in PRs

2023-10-11 Thread Etienne Chauchot
Hi, Cross-posting in that thread too: FYI, build issues for connectors related to architecture tests adding or removing violations is under fixing and tracked here (1) [1] https://issues.apache.org/jira/browse/FLINK-32563 Best Etienne Le 03/07/2023 à 10:05, Etienne Chauchot a écrit : Hi

Re: [DISCUSSION] test connectors against Flink master in PRs

2023-07-03 Thread Etienne Chauchot
Hi all, I wanted to post here the result of a discussion I had in private with Chesnay related to this subject. The question was regarding archunit with connectors: "How to deal with different archunit violations between 2 versions of Flink ?  If a violation is normal and should be added to

Re: [DISCUSSION] test connectors against Flink master in PRs

2023-06-29 Thread Etienne Chauchot
Hi Martijn, Thanks for your feedback. I makes total sense to me. I'll enable it for Cassandra. Best Etienne Le 29/06/2023 à 10:54, Martijn Visser a écrit : Hi Etienne, I think it all depends on the actual maintainers of the connector to make a decision on that: if their unreleased version

Re: [DISCUSSION] test connectors against Flink master in PRs

2023-06-29 Thread Martijn Visser
Hi Etienne, I think it all depends on the actual maintainers of the connector to make a decision on that: if their unreleased version of the connector should be compatible with a new Flink version, then they should test against it. For example, that's already done at Elasticsearch [1] and JDBC [2]

[DISCUSSION] test connectors against Flink master in PRs

2023-06-28 Thread Etienne Chauchot
Hi all, Connectors are external to flink. As such, they need to be tested against stable (released) versions of Flink. But I was wondering if it would make sense to test connectors in PRs also against latest flink master snapshot to allow to discover failures before merging the PRs, ** while