Re: [DISCUSSION] flink-connector-shared-utils release process

2023-11-29 Thread Etienne Chauchot
Thanks Leonard for the review. Best, Etienne Le 29/11/2023 à 08:25, Leonard Xu a écrit : Thanks Etienne for update the wiki, I just checked the change by comparing with history version, LGTM Best, Leonard 2023年11月28日 下午10:43,Etienne Chauchot 写道: Hi all, I just updated the doc:https://

Re: [DISCUSSION] flink-connector-shared-utils release process

2023-11-28 Thread Leonard Xu
Thanks Etienne for update the wiki, I just checked the change by comparing with history version, LGTM Best, Leonard > 2023年11月28日 下午10:43,Etienne Chauchot 写道: > > Hi all, > > I just updated the doc: > https://cwiki.apache.org/confluence/display/FLINK/Externalized+Connector+development > >

Re: [DISCUSSION] flink-connector-shared-utils release process

2023-11-28 Thread Etienne Chauchot
Hi all, I just updated the doc: https://cwiki.apache.org/confluence/display/FLINK/Externalized+Connector+development Best Etienne Le 27/11/2023 à 12:43, Etienne Chauchot a écrit : Sure! Le 23/11/2023 à 02:57, Leonard Xu a écrit : Thanks Etienne for driving this. - a flink-connector-sha

Re: [DISCUSSION] flink-connector-shared-utils release process

2023-11-27 Thread Etienne Chauchot
Sure! Le 23/11/2023 à 02:57, Leonard Xu a écrit : Thanks Etienne for driving this. - a flink-connector-shared-utils-*test* clone repo and a *io.github.user.flink*:flink-connector-parent custom artifact to be able to directly commit and install the artifact in the CI - a custom ci script that

Re: [DISCUSSION] flink-connector-shared-utils release process

2023-11-22 Thread Leonard Xu
Thanks Etienne for driving this. > - a flink-connector-shared-utils-*test* clone repo and a > *io.github.user.flink*:flink-connector-parent custom artifact to be able to > directly commit and install the artifact in the CI > - a custom ci script that does the cloning and mvn install in the ci.ym

Re: [DISCUSSION] flink-connector-shared-utils release process

2023-11-22 Thread Etienne Chauchot
I agree, it would make sense to add this process to https://cwiki.apache.org/confluence/display/FLINK/Continuous+Integration If people agree on the process and location, I can do the addition to the doc. Best Etienne Le 22/11/2023 à 14:29, Sergey Nuyanzin a écrit : yes, that's the way how

Re: [DISCUSSION] flink-connector-shared-utils release process

2023-11-22 Thread Sergey Nuyanzin
yes, that's the way how I tested my changes thanks for confirming that it's ok I wonder whether it should be documented somewhere, since it is not very obvious? On Wed, Nov 22, 2023 at 10:35 AM Etienne Chauchot wrote: > Hi Sergey, > > The other alternative that allows for autonomous testing of

Re: [DISCUSSION] flink-connector-shared-utils release process

2023-11-22 Thread Etienne Chauchot
Hi Sergey, The other alternative that allows for autonomous testing of ci changes (thanks @Chesnay for the suggestion) is to create you own repo: - a flink-connector-shared-utils-*test* clone repo and a *io.github.user.flink*:flink-connector-parent custom artifact to be able to directly comm

Re: [DISCUSSION] flink-connector-shared-utils release process

2023-11-21 Thread Sergey Nuyanzin
Hi Etienne thanks for starting this discussion +1 from my side for snapshots since I also faced same issue On Thu, Nov 9, 2023 at 11:21 AM Etienne Chauchot wrote: > Hi all, > > flink-connector-shared-utils contains utilities for connectors (parent > pom, ci scripts, template test connector p

[DISCUSSION] flink-connector-shared-utils release process

2023-11-09 Thread Etienne Chauchot
Hi all, flink-connector-shared-utils contains utilities for connectors (parent pom, ci scripts, template test connector project etc...). It is divided into 2 main branches: - parent_pom (1) containing just a pom.xml - ci_utils (2) containing the test project using the parent pom and the ci