Re: [DISCUSS] increase "state.backend.fs.memory-threshold" from 1K to 100K

2020-05-21 Thread Yu Li
> context.getOperatorStateStore().getUnionListState(stateDescriptor); > > > } > > > } > > > > > > @Override > > > public void run(SourceContext ctx) throws Exception { > > > while (running) { > > >

Re: [DISCUSS] increase "state.backend.fs.memory-threshold" from 1K to 100K

2020-05-20 Thread Stephan Ewen
eDescriptor); > > } > > } > > > > @Override > > public void run(SourceContext ctx) throws Exception { > > while (running) { > > synchronized (ctx.getCheckpointLock()) { > > ctx.collect(ThreadLocalRandom.current().nextInt()); &g

Re: [DISCUSS] increase "state.backend.fs.memory-threshold" from 1K to 100K

2020-05-20 Thread Yu Li
gt; @Override > public void cancel() { > running = false; > } >} > } > > Best > Yun Tang > > From: Stephan Ewen > Sent: Saturday, May 16, 2020 18:56 > To: dev > Cc: Till Rohrmann ; Piotr Nowojs

Re: [DISCUSS] increase "state.backend.fs.memory-threshold" from 1K to 100K

2020-05-16 Thread Yun Tang
ng = false; } } } Best Yun Tang From: Stephan Ewen Sent: Saturday, May 16, 2020 18:56 To: dev Cc: Till Rohrmann ; Piotr Nowojski Subject: Re: [DISCUSS] increase "state.backend.fs.memory-threshold" from 1K to 100K Okay, thank you for all the feedback. So we should defin

Re: [DISCUSS] increase "state.backend.fs.memory-threshold" from 1K to 100K

2020-05-16 Thread Stephan Ewen
; > > [1] > > > https://github.com/apache/flink/blob/32bd0944d0519093c0a4d5d809c6636eb3a7fc31/flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java#L752 > > > > Best > > Yun Tang > > > > ________ > > From: Stephan Ewen

Re: [DISCUSS] increase "state.backend.fs.memory-threshold" from 1K to 100K

2020-05-15 Thread Congxian Qiu
could be a trade-off, which benefit perhaps > > 99% users, but might bring harmful effects to 1% user with large-scale > > flink jobs. > > > > > > [1] > > > https://github.com/apache/flink/blob/c1ea6fcfd05c72a68739bda8bd16a2d1c15522c0/flink-runtime/src/main/java/org/apache/flink/runtime/checkp

Re: [DISCUSS] increase "state.backend.fs.memory-threshold" from 1K to 100K

2020-05-15 Thread Yun Tang
t Yun Tang From: Stephan Ewen Sent: Friday, May 15, 2020 16:53 To: dev Cc: Till Rohrmann ; Piotr Nowojski Subject: Re: [DISCUSS] increase "state.backend.fs.memory-threshold" from 1K to 100K I see, thanks for all the input. I agree with Yun Tang that t

Re: [DISCUSS] increase "state.backend.fs.memory-threshold" from 1K to 100K

2020-05-15 Thread Stephan Ewen
t; > From: Yu Li > Sent: Thursday, May 14, 2020 23:51 > To: Till Rohrmann > Cc: dev ; Piotr Nowojski > Subject: Re: [DISCUSS] increase "state.backend.fs.memory-threshold" from > 1K to 100K > > TL;DR: I have some reservations but tend

Re: [DISCUSS] increase "state.backend.fs.memory-threshold" from 1K to 100K

2020-05-14 Thread Yun Tang
emory-threshold" from 1K to 100K TL;DR: I have some reservations but tend to be +1 for the proposal, meanwhile suggest we have a more thorough solution in the long run. Please correct me if I'm wrong, but it seems the root cause of the issue is too many small files generated. I have some c

Re: [DISCUSS] increase "state.backend.fs.memory-threshold" from 1K to 100K

2020-05-14 Thread Yu Li
TL;DR: I have some reservations but tend to be +1 for the proposal, meanwhile suggest we have a more thorough solution in the long run. Please correct me if I'm wrong, but it seems the root cause of the issue is too many small files generated. I have some concerns for the case of session cluster

Re: [DISCUSS] increase "state.backend.fs.memory-threshold" from 1K to 100K

2020-05-14 Thread Till Rohrmann
I cannot say much about the concrete value but if our users have problems with the existing default values, then it makes sense to me to change it. One thing to check could be whether it is possible to provide a meaningful exception in case that the state size exceeds the frame size. At the moment

[DISCUSS] increase "state.backend.fs.memory-threshold" from 1K to 100K

2020-05-14 Thread Stephan Ewen
The parameter "state.backend.fs.memory-threshold" decides when a state will become a file and when it will be stored inline with the metadata (to avoid excessive amounts of small files). By default, this threshold is 1K - so every state above that size becomes a file. For many cases, this threshol