Re: [DISCUSS] URI NullPointerException in TestBaseUtils

2015-02-27 Thread Márton Balassi
+1 On Fri, Feb 27, 2015 at 11:32 AM, Szabó Péter wrote: > Yeah, I agree, it is at best a cosmetic issue. I just wanted to let you > know about it. > > Peter > > > 2015-02-27 11:10 GMT+01:00 Till Rohrmann : > > > Catching the NullPointerException and throwing an > IllegalArgumentException > > wit

Re: [DISCUSS] URI NullPointerException in TestBaseUtils

2015-02-27 Thread Szabó Péter
Yeah, I agree, it is at best a cosmetic issue. I just wanted to let you know about it. Peter 2015-02-27 11:10 GMT+01:00 Till Rohrmann : > Catching the NullPointerException and throwing an IllegalArgumentException > with a meaningful message might clarify things. > > Considering that it only aff

Re: [DISCUSS] URI NullPointerException in TestBaseUtils

2015-02-27 Thread Till Rohrmann
Catching the NullPointerException and throwing an IllegalArgumentException with a meaningful message might clarify things. Considering that it only affects the TestBaseUtils, it should not be big deal to change it. On Fri, Feb 27, 2015 at 10:30 AM, Szabó Péter wrote: > The following code snippe

[DISCUSS] URI NullPointerException in TestBaseUtils

2015-02-27 Thread Szabó Péter
The following code snippet in from TestBaseUtils: protected static File asFile(String path) { try { URI uri = new URI(path); if (uri.getScheme().equals("file")) { return new File(uri.getPath()); } else { throw new IllegalArgumentException("This path does not