Re: [DISCUSS] TravisCI status on GitHub Page

2017-03-21 Thread Bowen Li
ok, fair enough On Tue, Mar 21, 2017 at 11:00 AM, Stephan Ewen wrote: > @Bowen Li > > There are various discussions currently about reworking repository > structure, tests, even switching CI services. > I would be up for revisiting this questions once we care confident that the > CI infrastructu

Re: [DISCUSS] TravisCI status on GitHub Page

2017-03-21 Thread Stephan Ewen
@Bowen Li There are various discussions currently about reworking repository structure, tests, even switching CI services. I would be up for revisiting this questions once we care confident that the CI infrastructure does not mark "good state" as "broken". On Tue, Mar 21, 2017 at 3:02 PM, Ufuk C

Re: [DISCUSS] TravisCI status on GitHub Page

2017-03-21 Thread Ufuk Celebi
The tag says "errored" in case of the timeout. But I don't think it's a worthwhile discussion to have, so I just reverted the commit. On Tue, Mar 21, 2017 at 2:50 PM, Stephan Ewen wrote: > Copying my answer from JIRA: > > Many builds are marked as "failed" these days simply due to exceeding the

Re: [DISCUSS] TravisCI status on GitHub Page

2017-03-21 Thread Stephan Ewen
Copying my answer from JIRA: Many builds are marked as "failed" these days simply due to exceeding the 50 minute limit in one profile. The status kind of makes the project look bad without a reason. We have quasi never a broken master, and currently not even flaky tests :-) For a code base of tha

Re: [DISCUSS] TravisCI status on GitHub Page

2017-03-20 Thread Bowen Li
I would argue for benefits of having build status. Instead of letting people go through all docs and wikis to find how Flink build system works, it guides people directly to where builds actually happen and ramps up new contributors faster. When my local tests fail during development, the homepage

Re: [DISCUSS] TravisCI status on GitHub Page

2017-03-20 Thread Ufuk Celebi
I merged the PR and therefore obviously think it's fine. ;-) Didn't see Robert's comment in the issue though ("We once had the travis build status badge in our readme, but decided to remove it, because it often shows "Build failed" due to travis issues etc. This gives people the impression that our

[DISCUSS] TravisCI status on GitHub Page

2017-03-20 Thread Greg Hogan
We are now showing the TravisCI build status on Flink’s GitHub page. I think Robert’s comment in Jira may have gone unnoticed when the PR was committed. https://issues.apache.org/jira/browse/FLINK-6122 If not yet seeing the benefit even if bui