Re: [DISCUSS] Remove Combinable Annotation from DataSet API

2016-01-15 Thread Fabian Hueske
OK, I think we got a clear picture here. I'll update the corresponding JIRA issue FLINK-1045. Thanks, Fabian 2016-01-14 18:53 GMT+01:00 Henry Saputra : > +1 for approach #1 > > > > - Henry > > On Thu, Jan 14, 2016 at 5:35 AM, Chiwan Park > wrote: > > > I’m also for approach #1. Now is nice tim

Re: [DISCUSS] Remove Combinable Annotation from DataSet API

2016-01-14 Thread Henry Saputra
+1 for approach #1 - Henry On Thu, Jan 14, 2016 at 5:35 AM, Chiwan Park wrote: > I’m also for approach #1. Now is nice time to apply some API-breaking > changes. > > > On Jan 14, 2016, at 1:19 AM, Aljoscha Krettek > wrote: > > > > I’m also for Approach #1. I like simplifying things. > >> On

Re: [DISCUSS] Remove Combinable Annotation from DataSet API

2016-01-14 Thread Chiwan Park
I’m also for approach #1. Now is nice time to apply some API-breaking changes. > On Jan 14, 2016, at 1:19 AM, Aljoscha Krettek wrote: > > I’m also for Approach #1. I like simplifying things. >> On 13 Jan 2016, at 14:25, Vasiliki Kalavri wrote: >> >> Hi, >> >> ​+1 for removing the Combinable a

Re: [DISCUSS] Remove Combinable Annotation from DataSet API

2016-01-13 Thread Aljoscha Krettek
I’m also for Approach #1. I like simplifying things. > On 13 Jan 2016, at 14:25, Vasiliki Kalavri wrote: > > Hi, > > ​+1 for removing the Combinable annotation​. Approach 1 sounds like the > best option to me. > > > On 13 January 2016 at 14:11, Till Rohrmann wrote: > >> Hi Fabian, >> >> tha

Re: [DISCUSS] Remove Combinable Annotation from DataSet API

2016-01-13 Thread Vasiliki Kalavri
Hi, ​+1 for removing the Combinable annotation​. Approach 1 sounds like the best option to me. On 13 January 2016 at 14:11, Till Rohrmann wrote: > Hi Fabian, > > thanks for bringing this issue up. I agree with you that it would be nice > to remove the Combinable annotation if it is not really

Re: [DISCUSS] Remove Combinable Annotation from DataSet API

2016-01-13 Thread Till Rohrmann
Hi Fabian, thanks for bringing this issue up. I agree with you that it would be nice to remove the Combinable annotation if it is not really needed. Now if people are not aware of the Combinable interface then they might think that they are actually using combiners by simply implementing CombineFu

[DISCUSS] Remove Combinable Annotation from DataSet API

2016-01-13 Thread Fabian Hueske
Hi everybody, As part of the upcoming 1.0 release we are stabilizing Flink's APIs. I would like to start a discussion about removing the Combinable annotation from the DataSet API. # The Current State: The DataSet API offers two interface for combine functions, CombineFunction and GroupComb