Re: [DISCUSS] Releasing Flink 1.8.3

Hi all, Thank you all for fixing issues of 1.8.3 release! The VOTE mail thread of the first RC of 1.8.3 has already been brought up. I would appreciate it if you can help to check the release and VOTE for the RC1. Thanks, Hequn On Wed, Nov 27, 2019 at 11:36 AM Hequn Cheng wrote: > Hi Jincheng,

Re: [DISCUSS] Releasing Flink 1.8.3

Hi Jincheng, Thanks a lot for your timely help. I'm on my way to the release. Best, Hequn On Wed, Nov 27, 2019 at 7:36 AM jincheng sun wrote: > Hi Hequn, > > Thank you for your great job! Looking forward the first RC of 1.8.3 ! > BTW: The version of 1.8.4 already created here: > https://issues

Re: [DISCUSS] Releasing Flink 1.8.3

Hi Hequn, Thank you for your great job! Looking forward the first RC of 1.8.3 ! BTW: The version of 1.8.4 already created here: https://issues.apache.org/jira/projects/FLINK/versions/12346552 Best, Jincheng Hequn Cheng 于2019年11月26日周二 下午8:18写道： > Hi all, > > I would like to share with you that

Re: [DISCUSS] Releasing Flink 1.8.3

Hi all, I would like to share with you that all blockers are resolved now. If there are no more critical issues, I will create the first RC tomorrow and vote on it directly. Hope everything goes well! Thank you all for the help of fixing, reviewing, driving and discussions! Best, Hequn On Tue,

Re: [DISCUSS] Releasing Flink 1.8.3

Hi, @Ufuk Celebi Hi, we are very close now. There is one issue( FLINK-13995 ) left that I want to double-check with you guys. Once this is done, we can create the first RC. I already have some minor comments in the PR

Re: [DISCUSS] Releasing Flink 1.8.3

@Hequn: flink-shaded:9.0 is available in Maven central now. I think you can go ahead and create the first RC. :-) On Mon, Nov 25, 2019 at 7:47 AM Zhu Zhu wrote: > Hi Hequn, > > Looks we are not able to merge fix of FLINK-14735 to 1.8 very soon. > Given that this fix is for batch job only and bat

Re: [DISCUSS] Releasing Flink 1.8.3

Hi Hequn, Looks we are not able to merge fix of FLINK-14735 to 1.8 very soon. Given that this fix is for batch job only and batch is not very good in 1.8, I think it is a not blocker of release 1.8.3. So just don't be blocked by it and feel free to cut the RC when other blocking issues are resolve

Re: [DISCUSS] Releasing Flink 1.8.3

Hi Zhu Zhu, Thanks a lot for letting us know! We can't cut the first RC right now due to the wait of the flink-shade release, so go ahead. Theoretically, we will cut the first RC of 1.8.3 and vote for it once the release of flink-shade is done, but I will try my best to have it in 1.8.3. Hope we

Re: [DISCUSS] Releasing Flink 1.8.3

Hi Jincheng & Hequn Thanks for driving the releasing of 1.8.3. I am now working on FLINK-14735. The fix avoids duplicated input checking when scheduling ALL-to-ALL connected downstream consumers with ALL input constraints. The duplicated checking can cause severe performance issues for large scal

Re: [DISCUSS] Releasing Flink 1.8.3

Thanks Chesnay. I'm also +1 to release 1.8.3 asap without the changes for the Jackson version bump and leave those for a future release. Realistically, the flink-shaded release will take until mid next week or end of next week. But please correct me if you think that it should not take that long o

Re: [DISCUSS] Releasing Flink 1.8.3

I've kicked off a discussion about the next flink-shaded release, and have opened PRs for adding the opt-in profile to 1.8/1.9. On 15/11/2019 13:54, Hequn Cheng wrote: That's great, thank you very much! Ideally, we can kick off the release vote for the first RC of 1.8.3 within next week. :) On

Re: [DISCUSS] Releasing Flink 1.8.3

That's great, thank you very much! Ideally, we can kick off the release vote for the first RC of 1.8.3 within next week. :) On Fri, Nov 15, 2019 at 8:47 PM Chesnay Schepler wrote: > I'm not aware of any more planned changes to flink-shaded; so we could > start the release right away. > > On 15/1

Re: [DISCUSS] Releasing Flink 1.8.3

I'm not aware of any more planned changes to flink-shaded; so we could start the release right away. On 15/11/2019 13:44, Hequn Cheng wrote: Hi, @Chesnay Thanks a lot for the explanation. +1 to the opt-in approach for 1.8/1.9. @Ufuk Thank you for the nice summary. Looks good so far except tha

Re: [DISCUSS] Releasing Flink 1.8.3

Hi, @Chesnay Thanks a lot for the explanation. +1 to the opt-in approach for 1.8/1.9. @Ufuk Thank you for the nice summary. Looks good so far except that we need to postpone 1.8.3 a bit to first do a flink-shaded release. BTW, @chesnay when would we plan to release the flink-shaded with upgraded

Re: [DISCUSS] Releasing Flink 1.8.3

One small modification: the flink-shaded upgrade does not have to be part of the profile; since it is only intended for internal use anyway (and thus has limited exposure) we can be pretty sure this doesn't break anything. On 15/11/2019 12:23, Chesnay Schepler wrote: Ufuk's summary is correct

Re: [DISCUSS] Releasing Flink 1.8.3

Ufuk's summary is correct. There's a slight caveat in that we'd also have to bump the shade-plugin to 3.1.1 since it otherwise fails on jackson, but I have no concerns about this change. On 15/11/2019 12:19, Ufuk Celebi wrote: The opt-in approach seems reasonable to me. +1 to include the prof

Re: [DISCUSS] Releasing Flink 1.8.3

The opt-in approach seems reasonable to me. +1 to include the profiles in 1.8 and 1.9 without changing the default versions (including the default version of flink-shaded). As far as I can tell, the next steps would be: 1) Release flink-shaded with upgraded Jackson 2a) Bump the flink-shaded versi

Re: [DISCUSS] Releasing Flink 1.8.3

The opt-in approach would only be used for 1.8.3 / 1.9.2; on master (and thus starting from 1.10.0) it's not opt-in. I have only proposed it as an opt-in because a) we usually do not bump dependencies in bugfix releases and b) it's a short-term change that we aren't allowing to mature properly

Re: [DISCUSS] Releasing Flink 1.8.3

Hi Chesnay, Great to hear that jackson-2.10.1 works well on master. Really a good job! - Whether backport this change to 1.8/1.9 I had taken a quick look at the security vulnerabilities, some of them seem can lead to high-security problems, thus from my point of view, I'm in favor of adding the f

Re: [DISCUSS] Releasing Flink 1.8.3

So here's the state of things: The master of flink-shaded now uses jackson 2.10.1, which eliminates a whole category of security vulnerabilities. The flink master works perfectly fine with that version; 1.9 will likely do so too and 1.8 would require a minor adjustment. Hence, there may be v

Re: [DISCUSS] Releasing Flink 1.8.3

Hi Chesnay, Jincheng Sure, I think it's good to have these fixes. Thanks a lot for providing the information about the security vulnerabilities! @Chesnay Best, Hequn On Thu, Nov 14, 2019 at 10:07 AM jincheng sun wrote: > +1 for try to eliminate the security vulnerabilities. Great thanks for >

Re: [DISCUSS] Releasing Flink 1.8.3

+1 for try to eliminate the security vulnerabilities. Great thanks for doing this important work, Chesnay! What do you think Hequn ? Best, Jincheng Chesnay Schepler 于2019年11月13日周三 下午5:17写道： > It would be great if you could give me a day or 2 to check how easy it > would be to bump the various j

Re: [DISCUSS] Releasing Flink 1.8.3

It would be great if you could give me a day or 2 to check how easy it would be to bump the various jackson dependencies to eliminate a few security vulnerabilities. On 09/11/2019 05:10, jincheng sun wrote: Hi Flink devs, It has been more than 2 months since the 1.8.2 released. So, What do yo

Re: [DISCUSS] Releasing Flink 1.8.3

Hi all, Thanks a lot for your kindly reply and feedbacks. @Jincheng Thank you very much for providing the release help. @Yang Wang Thanks a lot for your PR. I think it is an important fix! I left some comments in FLINK-13184 and we can discuss whether this is a blocker there. I have gone over al

Re: [DISCUSS] Releasing Flink 1.8.3

Thanks Hequn to be in change of the release ! Best, Danny Chan 在 2019年11月9日 +0800 PM3:59，Hequn Cheng ，写道： > Hi Jincheng, > > Thanks for kicking this discussion off! > > +1 to the 1.8.3 release as it would be nice to have these important fixes > and also two > months have passed since the last rele

Re: [DISCUSS] Releasing Flink 1.8.3

Thanks for all of your feedback! Hi Yang, great thanks for working on FLINK-13184 and advancing this issue, we hope that more problems can be solved in 1.8.3. Hi Hequn, glad to hear that you want to be the Release Manager of flink 1.8.3. I believe that you will be a great RM, and I am very will

Re: [DISCUSS] Releasing Flink 1.8.3

Hi Jincheng, Hequn I am now working on FLINK-13184 and already attach a PR to fix this issue. I think it is important for large scale deployment on yarn(1000+ containers). It will accelerate TaskExecutor launch and reduce the pressure of hdfs. I hope it could be merge to 1.8.3. Best, Yang Yu Li

Re: [DISCUSS] Releasing Flink 1.8.3

+1 for starting the 1.8.3 release cycle. Thanks for watching and driving this forward jincheng! Also +1 for Hequn to be the 1.8.3 RM. Best Regards, Yu On Sat, 9 Nov 2019 at 23:36, Jark Wu wrote: > +1 for the 1.8.3 release and for Hequn being the RM. > Thanks Jincheng for the effort and help o

Re: [DISCUSS] Releasing Flink 1.8.3

+1 for the 1.8.3 release and for Hequn being the RM. Thanks Jincheng for the effort and help on the releasing. Best, Jark On Sat, 9 Nov 2019 at 15:59, Hequn Cheng wrote: > Hi Jincheng, > > Thanks for kicking this discussion off! > > +1 to the 1.8.3 release as it would be nice to have these im

Re: [DISCUSS] Releasing Flink 1.8.3

Hi Jincheng, Thanks for kicking this discussion off! +1 to the 1.8.3 release as it would be nice to have these important fixes and also two months have passed since the last release. Besides, I wonder if I can be the release manager of 1.8.3 or work with you together @Jincheng? It's always excit

Re: [DISCUSS] Releasing Flink 1.8.3

Hi Jincheng, Thanks a lot for bringing up this discussion. +1 for releasing 1.8.3. Regards, Dian On Sat, Nov 9, 2019 at 12:11 PM jincheng sun wrote: > Hi Flink devs, > > It has been more than 2 months since the 1.8.2 released. So, What do you > think about releasing Flink 1.8.3 soon? > > We al

[DISCUSS] Releasing Flink 1.8.3

Hi Flink devs, It has been more than 2 months since the 1.8.2 released. So, What do you think about releasing Flink 1.8.3 soon? We already have many important bug fixes in the release-1.8 branch (29 resolved issues). Most notable fixes are: - FLINK-14010 Dispatcher & JobManagers don't give up l