Re: [DISCUSS] Release 1.5.5 and 1.6.2

2018-10-17 Thread Chesnay Schepler
Alright, I will cut the release branches now. On 17.10.2018 10:06, Till Rohrmann wrote: I would be ok with Aljoscha's proposal to not revert FLINK-10354. Thus, the release branches should be good to create a first RC for 1.5.5 and 1.6.2 Cheers, Till On Wed, Oct 17, 2018 at 12:24 AM Till Rohrma

Re: [DISCUSS] Release 1.5.5 and 1.6.2

2018-10-17 Thread Till Rohrmann
I would be ok with Aljoscha's proposal to not revert FLINK-10354. Thus, the release branches should be good to create a first RC for 1.5.5 and 1.6.2 Cheers, Till On Wed, Oct 17, 2018 at 12:24 AM Till Rohrmann wrote: > My concern was that it changes Flink's behaviour in a non trivial way > which

Re: [DISCUSS] Release 1.5.5 and 1.6.2

2018-10-16 Thread Till Rohrmann
My concern was that it changes Flink's behaviour in a non trivial way which could break existing setups. It is true that Flink's exactly once guarantees are thwarted by that, though. The only problematic case is when users delete the savepoint files without the corresponding meta state savepoint f

Re: [DISCUSS] Release 1.5.5 and 1.6.2

2018-10-16 Thread Aljoscha Krettek
Hi, I think the "savepoints for recovery" change is a fix for likely violation of exactly-once guarantees while it has close to zero downsides in real-world use cases. Therefore I think we should not revert it and release the fix for 1.5.5 and 1.6.2. Best, Aljoscha > On 16. Oct 2018, at 13:48

Re: [DISCUSS] Release 1.5.5 and 1.6.2

2018-10-16 Thread Chesnay Schepler
I agree that these change the behavior of Flink and could cause issues for users, hence I would be in favor of reverting said changes. On 16.10.2018 13:46, Till Rohrmann wrote: Sorry for the late notification, but I think we have some changes in the release branches which we might consider for

Re: [DISCUSS] Release 1.5.5 and 1.6.2

2018-10-16 Thread Till Rohrmann
Sorry for the late notification, but I think we have some changes in the release branches which we might consider for reverting. 1) Savepoints being considered for recovery [1] The problem is that we change Flink's savepoint contract in the sense that savepoint's are no longer exclusively under t

Re: [DISCUSS] Release 1.5.5 and 1.6.2

2018-10-15 Thread Chesnay Schepler
My issues have been merged as well. I will cut the release branches in 3 hours. On 15.10.2018 22:11, Till Rohrmann wrote: FLINK-9932 has been merged. Cheers, Till On Mon, Oct 15, 2018 at 1:19 PM Till Rohrmann wrote: Thanks a lot for starting this discussion Chesnay. I fully agree that a ne

Re: [DISCUSS] Release 1.5.5 and 1.6.2

2018-10-15 Thread Till Rohrmann
FLINK-9932 has been merged. Cheers, Till On Mon, Oct 15, 2018 at 1:19 PM Till Rohrmann wrote: > Thanks a lot for starting this discussion Chesnay. I fully agree that a > new bug fix release would be justified. > > I'm currently working on FLINK-9932 which I would like to include in the > next b

Re: [DISCUSS] Release 1.5.5 and 1.6.2

2018-10-15 Thread Till Rohrmann
Thanks a lot for starting this discussion Chesnay. I fully agree that a new bug fix release would be justified. I'm currently working on FLINK-9932 which I would like to include in the next bug fix release. It should be done by the end of today. Cheers, Till On Mon, Oct 15, 2018 at 11:40 AM Ches

[DISCUSS] Release 1.5.5 and 1.6.2

2018-10-15 Thread Chesnay Schepler
Hello, we've accumulated various fixes for 1.5.5 (24) and 1.6.2 (37) that improve stability by quite a bit along with some neat usability fixes. I'm proposing to do the next bugfix releases soon (I suggest tomorrow as a tentative vote date), and volunteer to handle the release process for bo