Re: [DISCUSS] Offer Flink with Scala 2.11

2015-03-16 Thread Alexander Alexandrov
I'm fine with that, although I think that cross-building should be added to the roadmap for 2015. 2015-03-16 12:44 GMT+01:00 Robert Metzger : > Thank you for bringing new attention to this. > > After thinking a bit more about it, I would actually vote to NOT offer > pre-build suffixed packages. >

Re: [DISCUSS] Offer Flink with Scala 2.11

2015-03-16 Thread Robert Metzger
Thank you for bringing new attention to this. After thinking a bit more about it, I would actually vote to NOT offer pre-build suffixed packages. So far, the demand for Scala 2.11 has been low on the mailing list, and for those who want to use it, we have a good way to enable it manually. On Mon,

Re: [DISCUSS] Offer Flink with Scala 2.11

2015-03-16 Thread Alexander Alexandrov
Popping up this thread. The PR build passes and we need some sort of strategy (add suffix to packages or force manual build for 2.11) before we merge. 2015-03-11 19:15 GMT+01:00 Robert Metzger : > Thank you for opening the pull request. It looks great so far. > > There came up one question while

Re: [DISCUSS] Offer Flink with Scala 2.11

2015-03-11 Thread Robert Metzger
Thank you for opening the pull request. It looks great so far. There came up one question while discussing Alex changes in the PR: To make this change really usable for our users, we need to provide our users with different poms for each artifact, containing either Scala 2.10 or 2.11. Its basicall

Re: [DISCUSS] Offer Flink with Scala 2.11

2015-03-10 Thread Alexander Alexandrov
The PR is here: https://github.com/apache/flink/pull/477 Cheers! 2015-03-10 18:07 GMT+01:00 Alexander Alexandrov < alexander.s.alexand...@gmail.com>: > Yes, will do. > > 2015-03-10 16:39 GMT+01:00 Robert Metzger : > >> Very nice work. >> The changes are probably somewhat easy to merge. Except fo

Re: [DISCUSS] Offer Flink with Scala 2.11

2015-03-10 Thread Alexander Alexandrov
Yes, will do. 2015-03-10 16:39 GMT+01:00 Robert Metzger : > Very nice work. > The changes are probably somewhat easy to merge. Except for the version > properties in the parent pom, there should not be a bigger issue. > > Can you also add additional build profiles to travis for scala 2.11 ? > > O

Re: [DISCUSS] Offer Flink with Scala 2.11

2015-03-10 Thread Robert Metzger
Very nice work. The changes are probably somewhat easy to merge. Except for the version properties in the parent pom, there should not be a bigger issue. Can you also add additional build profiles to travis for scala 2.11 ? On Tue, Mar 10, 2015 at 2:50 PM, Alexander Alexandrov < alexander.s.alexa

Re: [DISCUSS] Offer Flink with Scala 2.11

2015-03-10 Thread Alexander Alexandrov
We have is almost ready here: https://github.com/stratosphere/flink/commits/scala_2.11_rebased I wanted to open a PR today 2015-03-10 11:28 GMT+01:00 Robert Metzger : > Hey Alex, > > I don't know the exact status of the Scala 2.11 integration. But I wanted > to point you to https://github.com/a

Re: [DISCUSS] Offer Flink with Scala 2.11

2015-03-10 Thread Robert Metzger
Hey Alex, I don't know the exact status of the Scala 2.11 integration. But I wanted to point you to https://github.com/apache/flink/pull/454, which is changing a huge portion of our maven build infrastructure. If you haven't started yet, it might make sense to base your integration onto that pull

Re: [DISCUSS] Offer Flink with Scala 2.11

2015-03-02 Thread Chiwan Park
+1 for Scala 2.11 Regards. Chiwan Park (Sent with iPhone) > On Mar 3, 2015, at 2:43 AM, Robert Metzger wrote: > > I'm +1 if this doesn't affect existing Scala 2.10 users. > > I would also suggest to add a scala 2.11 build to travis as well to ensure > everything is working with the different

Re: [DISCUSS] Offer Flink with Scala 2.11

2015-03-02 Thread Robert Metzger
I'm +1 if this doesn't affect existing Scala 2.10 users. I would also suggest to add a scala 2.11 build to travis as well to ensure everything is working with the different Hadoop/JVM versions. It shouldn't be a big deal to offer scala_version x hadoop_version builds for newer releases. You only n

Re: [DISCUSS] Offer Flink with Scala 2.11

2015-03-02 Thread Till Rohrmann
+1 for Scala 2.11 On Mon, Mar 2, 2015 at 5:02 PM, Alexander Alexandrov < alexander.s.alexand...@gmail.com> wrote: > Spark currently only provides pre-builds for 2.10 and requires custom build > for 2.11. > > Not sure whether this is the best idea, but I can see the benefits from a > project manag

Re: [DISCUSS] Offer Flink with Scala 2.11

2015-03-02 Thread Alexander Alexandrov
Spark currently only provides pre-builds for 2.10 and requires custom build for 2.11. Not sure whether this is the best idea, but I can see the benefits from a project management point of view... Would you prefer to have a {scala_version} × {hadoop_version} integrated on the website? 2015-03-02

Re: [DISCUSS] Offer Flink with Scala 2.11

2015-03-02 Thread Alexander Alexandrov
Profile will be needed for the quasiquotes dependency and the maven scalamacros plugin. 2015-03-02 16:48 GMT+01:00 Stephan Ewen : > Big +1 from my side! > > Does it have to be a Maven profile, or does a maven property work? (Profile > may be needed for quasiquotes dependency?) > > On Mon, Mar 2,

Re: [DISCUSS] Offer Flink with Scala 2.11

2015-03-02 Thread Aljoscha Krettek
+1 I also like it. We just have to figure out how we can publish two sets of release artifacts. On Mon, Mar 2, 2015 at 4:48 PM, Stephan Ewen wrote: > Big +1 from my side! > > Does it have to be a Maven profile, or does a maven property work? (Profile > may be needed for quasiquotes dependency?) >

Re: [DISCUSS] Offer Flink with Scala 2.11

2015-03-02 Thread Stephan Ewen
Big +1 from my side! Does it have to be a Maven profile, or does a maven property work? (Profile may be needed for quasiquotes dependency?) On Mon, Mar 2, 2015 at 4:36 PM, Alexander Alexandrov < alexander.s.alexand...@gmail.com> wrote: > Hi there, > > since I'm relying on Scala 2.11.4 on a proje

[DISCUSS] Offer Flink with Scala 2.11

2015-03-02 Thread Alexander Alexandrov
Hi there, since I'm relying on Scala 2.11.4 on a project I've been working on, I created a branch which updates the Scala version used by Flink from 2.10.4 to 2.11.4: https://github.com/stratosphere/flink/commits/scala_2.11 Everything seems to work fine and the PR contains minor changes compared