Re: [DISCUSS] Move docker development into versioned branches

2020-04-27 Thread Patrick Lucas
This also sounds good to me. The master branch will continue to be the publishing area for the release Dockerfiles and we can support changes between Flink versions without additional complexity. My only comment would be that I hope we can still keep eventual convergence in mind—it should be possi

Re: [DISCUSS] Move docker development into versioned branches

2020-04-27 Thread Till Rohrmann
Thanks for starting this discussion Chesnay. Your proposal sounds good to me. I can see how the current setup makes the development of version specific features impractical. Hence, +1 for the proposed changes. Cheers, Till On Mon, Apr 27, 2020 at 12:19 PM David Anderson wrote: > Makes sense to

Re: [DISCUSS] Move docker development into versioned branches

2020-04-27 Thread David Anderson
Makes sense to me. I think this would align well enough with user expectations, and be more straightforward. David On Thu, Apr 23, 2020 at 1:23 PM Chesnay Schepler wrote: > Hello everyone, > > Currently, all development in docker-flink occurs on the master branch, > for all releases at once. Th

[DISCUSS] Move docker development into versioned branches

2020-04-23 Thread Chesnay Schepler
Hello everyone, Currently, all development in docker-flink occurs on the master branch, for all releases at once. The master branch also serves as a publishing area for our docker files. This means that all versions share the same generators, templates (i.e., production code that we plugin i