Re: [DISCUSS] Merge batch and stream connector modules

2016-11-22 Thread Maximilian Michels
+1 On Tue, Nov 22, 2016 at 9:08 AM, Fabian Hueske wrote: > Hi all, > > should we do this refactoring for the 1.2 release? > If yes, I'll prepare a PR for that. > > Cheers, > Fabian > > 2016-09-26 13:55 GMT+02:00 Fabian Hueske : > >> Thanks everybody for your comments. >> >> I opened FLINK-4676 [1

Re: [DISCUSS] Merge batch and stream connector modules

2016-11-22 Thread Fabian Hueske
Hi all, should we do this refactoring for the 1.2 release? If yes, I'll prepare a PR for that. Cheers, Fabian 2016-09-26 13:55 GMT+02:00 Fabian Hueske : > Thanks everybody for your comments. > > I opened FLINK-4676 [1] for merging the connector modules. > > [1] https://issues.apache.org/jira/br

Re: [DISCUSS] Merge batch and stream connector modules

2016-09-26 Thread Fabian Hueske
Thanks everybody for your comments. I opened FLINK-4676 [1] for merging the connector modules. [1] https://issues.apache.org/jira/browse/FLINK-4676 2016-09-26 13:17 GMT+02:00 Robert Metzger : > +1 good suggestion. > > On Mon, Sep 26, 2016 at 1:03 PM, Stephan Ewen wrote: > > > The module would

Re: [DISCUSS] Merge batch and stream connector modules

2016-09-26 Thread Robert Metzger
+1 good suggestion. On Mon, Sep 26, 2016 at 1:03 PM, Stephan Ewen wrote: > The module would have both dependencies, but both are provided anyways, so > that would not be much of an issue, I think. > > On Mon, Sep 26, 2016 at 12:25 PM, Till Rohrmann > wrote: > > > I think this only holds true fo

Re: [DISCUSS] Merge batch and stream connector modules

2016-09-26 Thread Stephan Ewen
The module would have both dependencies, but both are provided anyways, so that would not be much of an issue, I think. On Mon, Sep 26, 2016 at 12:25 PM, Till Rohrmann wrote: > I think this only holds true for modules which depend on the batch or > streaming counter part, respectively. We could

Re: [DISCUSS] Merge batch and stream connector modules

2016-09-26 Thread Till Rohrmann
I think this only holds true for modules which depend on the batch or streaming counter part, respectively. We could refactor these modules by pulling out common types which are independent of streaming/batch and are used by the batch and streaming module. Cheers, Till On Fri, Sep 23, 2016 at 11:

Re: [DISCUSS] Merge batch and stream connector modules

2016-09-23 Thread Aljoscha Krettek
I don't think it's that easy. The streaming connectors have flink-streaming as dependency while the batch connectors have the batch dependencies. Combining them would mean that users always have all dependencies, right? On Thu, 22 Sep 2016 at 15:41 Stephan Ewen wrote: > +1 for Fabian's suggesti

Re: [DISCUSS] Merge batch and stream connector modules

2016-09-22 Thread Stephan Ewen
+1 for Fabian's suggestion On Thu, Sep 22, 2016 at 3:25 PM, Swapnil Chougule wrote: > +1 > It will be good to have one module flink-connectors (union of streaming and > batch connectors). > > Regards, > Swapnil > > On Thu, Sep 22, 2016 at 6:35 PM, Fabian Hueske wrote: > > > Hi everybody, > > >

Re: [DISCUSS] Merge batch and stream connector modules

2016-09-22 Thread Swapnil Chougule
+1 It will be good to have one module flink-connectors (union of streaming and batch connectors). Regards, Swapnil On Thu, Sep 22, 2016 at 6:35 PM, Fabian Hueske wrote: > Hi everybody, > > right now, we have two separate Maven modules for batch and streaming > connectors (flink-batch-connectors

[DISCUSS] Merge batch and stream connector modules

2016-09-22 Thread Fabian Hueske
Hi everybody, right now, we have two separate Maven modules for batch and streaming connectors (flink-batch-connectors and flink-streaming-connectors) that contain modules for the individual external systems and storage formats such as HBase, Cassandra, Avro, Elasticsearch, etc. Some of these sys