Re: [DISCUSS] Introduce flink-connector-hive-xx modules

2020-03-05 Thread Bowen Li
Hi Jingsong, I think I misunderstood you. So your argument is that, to support hive 1.0.0 - 1.2.2, we are actually using Hive 1.2.2 and thus we name the flink module as "flink-connector-hive-1.2", right? It makes sense to me now. +1 for this change. Cheers, Bowen On Thu, Mar 5, 2020 at 6:53 PM

Re: [DISCUSS] Introduce flink-connector-hive-xx modules

2020-03-05 Thread Jingsong Li
Hi Bowen, My idea is to directly provide the really dependent version, such as hive 1.2.2, our jar name is hive 1.2.2, so that users can directly and clearly know the version. As for which metastore is supported, we can guide it in the document, otherwise, write 1.0, and the result version is inde

Re: [DISCUSS] Introduce flink-connector-hive-xx modules

2020-03-05 Thread Bowen Li
> I have some hesitation, because the actual version number can better reflect the actual dependency. For example, if the user also knows the field hiveVersion[1]. He may enter the wrong hiveVersion because of the name, or he may have the wrong expectation for the hive built-in functions. Sorry, I

Re: [DISCUSS] Introduce flink-connector-hive-xx modules

2020-03-04 Thread Jingsong Li
Hi Bowen, thanks for your reply. > will there be a base module like "flink-connector-hive-base" which holds all the common logic of these proposed modules Maybe we don't need, their implementation is only "pom.xml". Different versions have different dependencies. > it's more common to set the ve

Re: [DISCUSS] Introduce flink-connector-hive-xx modules

2020-03-04 Thread Bowen Li
Thanks Jingsong for your explanation! I'm +1 for this initiative. According to your description, I think it makes sense to incorporate support of Hive 2.2 to that of 2.0/2.1 and reducing the number of ranges to 4. A couple minor followup questions: 1) will there be a base module like "flink-conne

Re: [DISCUSS] Introduce flink-connector-hive-xx modules

2020-03-04 Thread Jingsong Li
Thanks Bowen for involving. > why you proposed segregating hive versions into the 5 ranges above? & what different Hive features are supported in the 5 ranges? For only higher client dependencies version support lower hive metastore versions: - Hive 1.0.0 - 1.2.2, thrift change is OK, only hive d

Re: [DISCUSS] Introduce flink-connector-hive-xx modules

2020-03-04 Thread Bowen Li
Thanks, Jingsong, for bringing this up. We've received lots of feedbacks in the past few months that the complexity involved in different Hive versions has been quite painful for users to start with. So it's great to step forward and deal with such issue. Before getting on a decision, can you plea

[DISCUSS] Introduce flink-connector-hive-xx modules

2020-03-04 Thread Jingsong Lee
Hi all, I'd like to propose introduce flink-connector-hive-xx modules. We have documented the dependencies detailed information[2]. But still has some inconvenient: - Too many versions, users need to pick one version from 8 versions. - Too many versions, It's not friendly to our developers either