Re: [DISCUSS] FLIP-Draft - Amazon CloudWatch Metric Sink Connector

2025-04-21 Thread Daren Wong
Hi Robert, Thanks for the question, I took a look and agree with your latter point that it is not necessary as Flink StatsD metrics reporter works with CloudWatch Agent StatsD interface. Regards, Daren > On 18 Apr 2025, at 15:57, Robert Metzger wrote: > > Hi, > quick, somewhat related questi

Re: [DISCUSS] FLIP-Draft - Amazon CloudWatch Metric Sink Connector

2025-04-18 Thread Robert Metzger
Hi, quick, somewhat related question: There is no Cloudwatch metrics reporter for Flink yet. Would it make sense to add one, or is that not necessary because Cloudwatch supports other metrics reporters (statds?) Best, Robert On Wed, Apr 16, 2025 at 10:50 AM Daren Wong wrote: > Hi devs, > > Th

Re: [DISCUSS] FLIP-Draft - Amazon CloudWatch Metric Sink Connector

2025-04-16 Thread Daren Wong
Hi devs, Thanks Hong for the help with moving the Draft into a FLIP. I have opened a Vote thread for the FLIP here https://lists.apache.org/thread/48rdzjbh8wvo8dr9q15vlsh1f5cojx4q. I will keep this discussion thread open and please feel free to continue leaving any feedback and questions here.

Re: [DISCUSS] FLIP-Draft - Amazon CloudWatch Metric Sink Connector

2025-04-14 Thread Wong, Daren
Hi Keith, Thanks for the feedback and questions > 1. Can you elaborate what are the possible configuration key and their > examples for CloudWatchSinkProperties? In addition to standard AsyncSink configuration key, i.e “sink.batch.max-size“, the other possible configuration keys for TableAPI a

Re: [DISCUSS] FLIP-Draft - Amazon CloudWatch Metric Sink Connector

2025-04-14 Thread Keith Lee
Hello Daren, Thank you for the FLIP. Questions below: 1. Can you elaborate what are the possible configuration key and their examples for CloudWatchSinkProperties? 2. I see that MetricWriteRequest's unit field is of String type. Is there a motivation of using String type as opposed to StandardUn

Re: [DISCUSS] FLIP-Draft - Amazon CloudWatch Metric Sink Connector

2025-04-11 Thread Wong, Daren
Hi Hong, Thanks for the comments and suggestions, really appreciate it! > Clarify Cloudwatch API limitations and handling in the sink. [1] Great to see > we're being explicit with the Java API model! Let's be explicit about the > PutMetricsData API constraints and how we handle them (it would

Re: [DISCUSS] FLIP-Draft - Amazon CloudWatch Metric Sink Connector

2025-04-11 Thread Wong, Daren
Hi Ahmed, Thanks for the detailed feedback and questions Just a quick note that after gathering you and Hong’s feedback, I have updated the design to remove “CloudWatchMetricInput” model and introduce “MetricWriteRequest” instead, and we will expose an element converter that user can implement

RE: Re: [DISCUSS] FLIP-Draft - Amazon CloudWatch Metric Sink Connector

2025-04-09 Thread Daren Wong
Hi Hong, Thanks for the comments and suggestions, really appreciate it! > Clarify Cloudwatch API limitations and handling in the sink. [1] Great to see > we're being explicit with the Java API model! Let's be explicit about the > PutMetricsData API constraints and how we handle them (it would

RE: Re: [DISCUSS] FLIP-Draft - Amazon CloudWatch Metric Sink Connector

2025-04-09 Thread Daren Wong
Hi Ahmed, Thanks for the detailed feedback and questions Just a quick note that after gathering you and Hong’s feedback, I have updated the design to remove “CloudWatchMetricInput” model and introduce “MetricWriteRequest” instead, and we will expose an element converter that user can implement

Re: [DISCUSS] FLIP-Draft - Amazon CloudWatch Metric Sink Connector

2025-04-08 Thread Hong Liang
Hi Daren, Thanks for the contribution — exciting to see support for new sinks! I’ve added a few comments and suggestions below: 1. Clarify Cloudwatch API limitations and handling in the sink. [1] Great to see we're being explicit with the Java API model! Let's be explicit about the PutMetricsData

Re: [DISCUSS] FLIP-Draft - Amazon CloudWatch Metric Sink Connector

2025-04-07 Thread Ahmed Hamdy
Hi Daren thanks for the FLIP Just a couple of questions and comments? > Usable in both DataStream and Table API/SQL What about python API? this is sth we should consider ahead since the abstract element converter doesn't have a Flink type mapping to be used from python, this is a issue we faced w

[DISCUSS] FLIP-Draft - Amazon CloudWatch Metric Sink Connector

2025-04-07 Thread Wong, Daren
Hi Dev, I would like to start a discussion about FLIP: Amazon CloudWatch Metric Sink Connector https://docs.google.com/document/d/1G2sQogV8S6M51qeAaTmvpClOSvklejjEXbRFFCv_T-c/edit?usp=sharing This FLIP is proposing to add support for Amazon CloudWatch Metric sink in flink-connector-aws repo. L