Re: [DISCUSS] FLIP-66: Support time attribute in SQL DDL

2019-09-23 Thread Kurt Young
For histogram-based watermark strategy, one possible solution is that we still use the stateless scalar function, and keep the stateful objects directly in the function. By doing that we will loose some information after the job get restarted, but I think it might acceptable because histogram-based

Re: [DISCUSS] FLIP-66: Support time attribute in SQL DDL

2019-09-23 Thread Jark Wu
Hi, Thanks Fabian for your reply. I agree with your point that the histogram-based case need the function to be stateful which is not supported currently and in this design. Maybe we can support stateful scalar function like TableAggregateFunction. We can further discuss how to support this in the

Re: [DISCUSS] FLIP-66: Support time attribute in SQL DDL

2019-09-20 Thread Fabian Hueske
Hi Jark, Thanks for the summary! I like the proposal! It makes it very clear that an event time attribute is an existing column on which watermark metadata is defined whereas a processing time attribute is a computed field. I have one comment regarding the section on "Complex Watermark Strategie

Re: [DISCUSS] FLIP-66: Support time attribute in SQL DDL

2019-09-19 Thread Jark Wu
Hi everyone, Thanks all for the valuable suggestions and feedbacks so far. Before starting the vote, I would like to summarize the proposed DDL syntax in the mailing list. ## Rowtime Attribute (Watermark Syntax) CREATE TABLE table_name ( WATERMARK FOR AS ) WITH ( ... ) It marks an existin

Re: [DISCUSS] FLIP-66: Support time attribute in SQL DDL

2019-09-18 Thread Kurt Young
+1 to start vote process. Best, Kurt On Thu, Sep 19, 2019 at 10:54 AM Jark Wu wrote: > Hi everyone, > > Thanks all for joining the discussion in the doc[1]. > It seems that the discussion is converged and there is a consensus on the > current FLIP document. > If there is no objection, I would

Re: [DISCUSS] FLIP-66: Support time attribute in SQL DDL

2019-09-18 Thread Jark Wu
Hi everyone, Thanks all for joining the discussion in the doc[1]. It seems that the discussion is converged and there is a consensus on the current FLIP document. If there is no objection, I would like to convert it into cwiki FLIP page and start voting process. For more details, please refer to

Re: [DISCUSS] FLIP-66: Support time attribute in SQL DDL

2019-09-16 Thread Kurt Young
After some review and discussion in the google document, I think it's time to convert this design to a cwiki flip page and start voting process. Best, Kurt On Mon, Sep 9, 2019 at 7:46 PM Jark Wu wrote: > Hi all, > > Thanks all for so much feedbacks received in the doc so far. > I saw a general

Re: [DISCUSS] FLIP-66: Support time attribute in SQL DDL

2019-09-09 Thread Jark Wu
Hi all, Thanks all for so much feedbacks received in the doc so far. I saw a general agreement on using computed column to support proctime attribute and extract timestamps. So we will prepare a computed column FLIP and share in the dev ML soon. Feel free to leave more comments! Best, Jark On

Re: [DISCUSS] FLIP-66: Support time attribute in SQL DDL

2019-09-05 Thread Dian Fu
Hi Jark, Thanks for bringing up this discussion and the detailed design doc. This is definitely a critical feature for streaming SQL jobs. I have left a few comments in the design doc. Thanks, Dian > 在 2019年9月6日,上午11:48,Forward Xu 写道: > > Thanks Jark for this topic, This will be very useful.

Re: [DISCUSS] FLIP-66: Support time attribute in SQL DDL

2019-09-05 Thread Forward Xu
Thanks Jark for this topic, This will be very useful. Best, ForwardXu Danny Chan 于2019年9月6日周五 上午11:26写道: > Thanks Jark for bring up this topic, this is definitely an import feature > for the SQL, especially the DDL users. > > I would spend some time to review this design doc, really thanks. >

Re: [DISCUSS] FLIP-66: Support time attribute in SQL DDL

2019-09-05 Thread Danny Chan
Thanks Jark for bring up this topic, this is definitely an import feature for the SQL, especially the DDL users. I would spend some time to review this design doc, really thanks. Best, Danny Chan 在 2019年9月6日 +0800 AM11:19,Jark Wu ,写道: > Hi everyone, > > I would like to start discussion about how

[DISCUSS] FLIP-66: Support time attribute in SQL DDL

2019-09-05 Thread Jark Wu
Hi everyone, I would like to start discussion about how to support time attribute in SQL DDL. In Flink 1.9, we already introduced a basic SQL DDL to create a table. However, it doesn't support to define time attributes. This makes users can't apply window operations on the tables created by DDL wh